Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add end of standard support field to EKS-A bundle #9115

Merged

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Dec 27, 2024

Issue #, if available:
#2855

Description of changes:
This PR adds the new endOfStandardSupport date to the EKS-A bundle for extended kubernetes version support. This date is fetched from the EKSD_LATEST_RELEASES file which was updated in #4174.

NOTE: The testdata file is not updated yet in this PR as #4174 is not merged yet. Once that is merged, I will re-run the make -C release update-bundle-golden-files target to update the testdata file with the field.

Testing (if applicable):

make eks-a
make lint
make unit-test
make generate
make generate-manifests
make release-manifests
make -C release build
make -C release manifests
make -C release update-bundle-golden-files

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 27, 2024
@sp1999
Copy link
Member Author

sp1999 commented Dec 27, 2024

/approve
/hold

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.35%. Comparing base (2d73db2) to head (70648ce).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9115      +/-   ##
==========================================
- Coverage   72.41%   72.35%   -0.07%     
==========================================
  Files         578      585       +7     
  Lines       45589    45686      +97     
==========================================
+ Hits        33015    33055      +40     
- Misses      10838    10892      +54     
- Partials     1736     1739       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sp1999
Copy link
Member Author

sp1999 commented Dec 31, 2024

/unhold

@sp1999
Copy link
Member Author

sp1999 commented Dec 31, 2024

/hold

@sp1999
Copy link
Member Author

sp1999 commented Jan 2, 2025

/unhold

@rajeshvenkata
Copy link
Member

/lgtm

@eks-distro-bot eks-distro-bot merged commit 4783df3 into aws:main Jan 2, 2025
12 checks passed
@sp1999 sp1999 deleted the add-end-of-standard-support-date-to-bundle branch January 2, 2025 05:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants