Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license token string to cluster spec #9112

Merged
merged 1 commit into from
Dec 30, 2024

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Dec 25, 2024

Issue #, if available:
#2855

Description of changes:
This PR adds a new optional licenseToken string to the cluster spec for extended kubernetes version support.

Testing (if applicable):

make eks-a
make build-all-test-binaries
make lint
make unit-test
make generate
make generate-manifests
make release-manifests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@sp1999
Copy link
Member Author

sp1999 commented Dec 25, 2024

/approve

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 25, 2024
@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Dec 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.42%. Comparing base (1b040bf) to head (d70d156).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9112   +/-   ##
=======================================
  Coverage   72.41%   72.42%           
=======================================
  Files         578      578           
  Lines       45589    45592    +3     
=======================================
+ Hits        33015    33018    +3     
  Misses      10838    10838           
  Partials     1736     1736           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sp1999 sp1999 force-pushed the add-license-token-to-cluster-spec branch from 3a24150 to 09ff82e Compare December 25, 2024 21:31
@eks-distro-bot eks-distro-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 25, 2024
@sp1999 sp1999 force-pushed the add-license-token-to-cluster-spec branch from 09ff82e to d70d156 Compare December 25, 2024 21:42
@sp1999
Copy link
Member Author

sp1999 commented Dec 26, 2024

/hold

@sp1999
Copy link
Member Author

sp1999 commented Dec 30, 2024

/unhold

@eks-distro-bot eks-distro-bot merged commit 420e518 into aws:main Dec 30, 2024
13 checks passed
@sp1999 sp1999 deleted the add-license-token-to-cluster-spec branch December 31, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants