Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instructions for embedded images: #9076

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

jacobweinstock
Copy link
Member

Issue #, if available:

Description of changes:
For EKS Anywhere >= v0.21.0 embedded images are required when building HookOS.

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

For EKS Anywhere >= v0.21.0 embedded images are required
when building HookOS.

Signed-off-by: Jacob Weinstock <[email protected]>
@jacobweinstock
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobweinstock

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added approved size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 13, 2024
Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.41%. Comparing base (01d134a) to head (2e9b5bc).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9076      +/-   ##
==========================================
+ Coverage   72.37%   72.41%   +0.03%     
==========================================
  Files         578      578              
  Lines       45451    45589     +138     
==========================================
+ Hits        32897    33012     +115     
- Misses      10824    10840      +16     
- Partials     1730     1737       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rahulbabu95
Copy link
Member

/lgtm

@eks-distro-bot eks-distro-bot merged commit 2966308 into aws:main Dec 23, 2024
8 checks passed
@jacobweinstock
Copy link
Member Author

/cherrypick release-0.21

@eks-distro-pr-bot
Copy link
Contributor

@jacobweinstock: new pull request created: #9105

In response to this:

/cherrypick release-0.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants