Add Nutanix CCM ignore node IPs list #9069

adiantum · 2024-12-12T03:34:14Z

Description of changes:
Add kube-vip to CCM node ip addresses ignore list.
Paliative solution to fix bug with LB ip pool ranges and kube vip interception with node ip addresses.

Testing (if applicable):

2024-12-13T11:11:41.754Z        V6      Executing command       {"cmd": "/usr/bin/docker version --format {{.Client.Version}}"}
2024-12-13T11:11:41.778Z        V6      Executing command       {"cmd": "/usr/bin/docker info --format '{{json .MemTotal}}'"}
2024-12-13T11:11:41.826Z        V4      Reading bundles manifest        {"url": "bin/local-bundle-release.yaml"}
2024-12-13T11:11:41.846Z        V4      Using CAPI provider versions    {"Core Cluster API": "v1.7.2+a291d11", "Kubeadm Bootstrap": "v1.7.2+7ff41e6", "Kubeadm Control Plane": "v1.7.2+21ec27b", "External etcd Bootstrap": "v1.0.15+8ff9752", "External etcd Controller": "v1.0.24+97d1754", "Cluster API Provider Nutanix": "v1.3.5+d704f66"}
2024-12-13T11:11:42.155Z        V5      Retrier:        {"timeout": "2562047h47m16.854775807s", "backoffFactor": null}
2024-12-13T11:11:42.155Z        V2      Pulling docker image    {"image": "public.ecr.aws/l0g8r8j6/eks-anywhere-cli-tools:v0.21.1-eks-a-v0.20.10-dev-build.6"}
2024-12-13T11:11:42.155Z        V6      Executing command       {"cmd": "/usr/bin/docker pull public.ecr.aws/l0g8r8j6/eks-anywhere-cli-tools:v0.21.1-eks-a-v0.20.10-dev-build.6"}
2024-12-13T11:11:42.738Z        V5      Retry execution successful      {"retries": 1, "duration": "583.249265ms"}
2024-12-13T11:11:42.739Z        V3      Initializing long running container     {"name": "eksa_1734088302155670328", "image": "public.ecr.aws/l0g8r8j6/eks-anywhere-cli-tools:v0.21.1-eks-a-v0.20.10-dev-build.6"}
2024-12-13T11:11:42.739Z        V6      Executing command       {"cmd": "/usr/bin/docker run -d --name eksa_1734088302155670328 --network host -w /home/ubuntu/eksa-tests/ccm-ips -v /var/run/docker.sock:/var/run/docker.sock -v /home/ubuntu/eksa-tests/ccm-ips:/home/ubuntu/eksa-tests/ccm-ips -v /home/ubuntu/eksa-tests/ccm-ips:/home/ubuntu/eksa-tests/ccm-ips --entrypoint sleep public.ecr.aws/l0g8r8j6/eks-anywhere-cli-tools:v0.21.1-eks-a-v0.20.10-dev-build.6 infinity"}
2024-12-13T11:11:42.905Z        V0      Using the new workflow using the controller for management cluster create
2024-12-13T11:11:42.906Z        V4      Task start      {"task_name": "setup-validate"}
2024-12-13T11:11:42.906Z        V0      Performing setup and validations
2024-12-13T11:11:42.906Z        V0      ValidateClusterSpec for Nutanix datacenter      {"NutanixDatacenter": "eksa-ntnx-fiql-fix"}
2024-12-13T11:11:48.349Z        V0      ✅ Nutanix Provider setup is valid
2024-12-13T11:11:48.349Z        V0      ✅ Validate OS is compatible with registry mirror configuration
2024-12-13T11:11:48.349Z        V0      ✅ Validate certificate for registry mirror
2024-12-13T11:11:48.349Z        V0      ✅ Validate authentication for git provider
2024-12-13T11:11:48.349Z        V0      ✅ Validate cluster's eksaVersion matches EKS-A version
2024-12-13T11:11:48.349Z        V4      Task finished   {"task_name": "setup-validate", "duration": "5.443220267s"}
2024-12-13T11:11:48.349Z        V4      ----------------------------------
2024-12-13T11:11:48.349Z        V4      Task start      {"task_name": "bootstrap-cluster-init"}
2024-12-13T11:11:48.349Z        V0      Creating new bootstrap cluster
...
2024-12-13T11:25:57.715Z        V4      ----------------------------------
2024-12-13T11:25:57.715Z        V4      Task start      {"task_name": "write-cluster-config"}
2024-12-13T11:25:57.715Z        V0      Writing cluster config file
2024-12-13T11:25:57.719Z        V4      Task finished   {"task_name": "write-cluster-config", "duration": "4.627021ms"}
2024-12-13T11:25:57.719Z        V4      ----------------------------------
2024-12-13T11:25:57.719Z        V4      Task start      {"task_name": "delete-kind-cluster"}
2024-12-13T11:25:57.719Z        V0      Deleting bootstrap cluster
2024-12-13T11:25:57.719Z        V5      Retrier:        {"timeout": "2562047h47m16.854775807s", "backoffFactor": null}
2024-12-13T11:25:57.719Z        V6      Executing command       {"cmd": "/usr/bin/docker exec -i eksa_1734088302155670328 kind get clusters"}
2024-12-13T11:25:57.850Z        V5      Executed kind get clusters      {"response": "eksa-ntnx-fiql-fix-eks-a-cluster\n"}
2024-12-13T11:25:57.850Z        V5      Retry execution successful      {"retries": 1, "duration": "131.205203ms"}
2024-12-13T11:25:57.850Z        V5      Retrier:        {"timeout": "2562047h47m16.854775807s", "backoffFactor": null}
2024-12-13T11:25:57.851Z        V6      Executing command       {"cmd": "/usr/bin/docker exec -i eksa_1734088302155670328 kubectl get customresourc
edefinition clusters.cluster.x-k8s.io --kubeconfig eksa-ntnx-fiql-fix/generated/eksa-ntnx-fiql-fix.kind.kubeconfig"}
2024-12-13T11:25:57.990Z        V5      Retry execution successful      {"retries": 1, "duration": "139.818752ms"}
2024-12-13T11:25:57.990Z        V5      Retrier:        {"timeout": "2562047h47m16.854775807s", "backoffFactor": null}
2024-12-13T11:25:57.990Z        V6      Executing command       {"cmd": "/usr/bin/docker exec -i eksa_1734088302155670328 kubectl get clusters.clus
ter.x-k8s.io -o json --kubeconfig eksa-ntnx-fiql-fix/generated/eksa-ntnx-fiql-fix.kind.kubeconfig --namespace eksa-system"}
2024-12-13T11:25:58.145Z        V5      Retry execution successful      {"retries": 1, "duration": "154.579966ms"}
2024-12-13T11:25:58.145Z        V5      Retrier:        {"timeout": "2562047h47m16.854775807s", "backoffFactor": null}
2024-12-13T11:25:58.145Z        V4      Deleting kind cluster   {"name": "eksa-ntnx-fiql-fix-eks-a-cluster"}
2024-12-13T11:25:58.145Z        V6      Executing command       {"cmd": "/usr/bin/docker exec -i eksa_1734088302155670328 kind delete cluster --nam
e eksa-ntnx-fiql-fix-eks-a-cluster"}
2024-12-13T11:25:59.192Z        V5      Retry execution successful      {"retries": 1, "duration": "1.046486466s"}
2024-12-13T11:25:59.192Z        V0      🎉 Cluster created!
2024-12-13T11:25:59.192Z        V4      Task finished   {"task_name": "delete-kind-cluster", "duration": "1.472437753s"}
2024-12-13T11:25:59.192Z        V4      ----------------------------------
2024-12-13T11:25:59.192Z        V4      Task start      {"task_name": "install-curated-packages"}
--------------------------------------------------------------------------------------
The Amazon EKS Anywhere Curated Packages are only available to customers with the
Amazon EKS Anywhere Enterprise Subscription
--------------------------------------------------------------------------------------
...

Generated CCM config with ignored IP list (only kube-vip):

Documentation added/planned (if applicable):
not required

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

eks-distro-bot · 2024-12-12T03:34:20Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign panktishah26 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

eks-distro-bot · 2024-12-12T03:34:29Z

Hi @adiantum. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

abhinavmpandey08 · 2024-12-12T16:39:32Z

pkg/api/v1alpha1/nutanixdatacenterconfig_types.go

+	// CcmExcludeIPs is the optional list of IP addresses that should be excluded from the CCM IP pool for nodes.
+	// List should be valid IP addresses and IP address ranges.
+	// +optional
+	CcmExcludeNodeIPs []string `json:"ccmExcludeNodeIPs,omitempty"`


We shouldn't make API changes in v0.20 as it would break upgrades from v0.20 to v0.21

pkg/providers/nutanix/template.go

abhinavmpandey08 · 2024-12-13T21:36:44Z

/ok-to-test

BUGFIX Add Add Nutanix CCM ignore node IPs list

090ab32

eks-distro-bot added the needs-ok-to-test label Dec 12, 2024

eks-distro-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 12, 2024

abhinavmpandey08 reviewed Dec 12, 2024

View reviewed changes

Get rid of API changes

6e8c8a7

abhinavmpandey08 reviewed Dec 13, 2024

View reviewed changes

pkg/providers/nutanix/template.go Outdated Show resolved Hide resolved

pkg/providers/nutanix/template.go Outdated Show resolved Hide resolved

adiantum added 2 commits December 13, 2024 21:22

Fix comments

6360551

Fix linter errors

b965147

eks-distro-bot added ok-to-test and removed needs-ok-to-test labels Dec 13, 2024

Fix linter error

c2b36b5

adiantum closed this Dec 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Nutanix CCM ignore node IPs list #9069

Add Nutanix CCM ignore node IPs list #9069

adiantum commented Dec 12, 2024 •

edited

Loading

eks-distro-bot commented Dec 12, 2024

eks-distro-bot commented Dec 12, 2024

abhinavmpandey08 Dec 12, 2024

adiantum Dec 13, 2024

abhinavmpandey08 commented Dec 13, 2024

Add Nutanix CCM ignore node IPs list #9069

Add Nutanix CCM ignore node IPs list #9069

Conversation

adiantum commented Dec 12, 2024 • edited Loading

eks-distro-bot commented Dec 12, 2024

eks-distro-bot commented Dec 12, 2024

abhinavmpandey08 Dec 12, 2024

Choose a reason for hiding this comment

adiantum Dec 13, 2024

Choose a reason for hiding this comment

abhinavmpandey08 commented Dec 13, 2024

adiantum commented Dec 12, 2024 •

edited

Loading