Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of FIQL in Nutanix API list methods #8997

Merged
merged 1 commit into from
Nov 22, 2024
Merged

Get rid of FIQL in Nutanix API list methods #8997

merged 1 commit into from
Nov 22, 2024

Conversation

adiantum
Copy link
Contributor

Description of changes:
FIQL is deprecated and contains well-known bugs. This patch get rid of FIQL for all list requests to Nutanix PC API.

Testing (if applicable):

$ eksctl anywhere create cluster -f ./cluster-eksa-ntnx-fiql-fix.yaml -v10 --bundles-override ./bin/local-bundle-release.yaml
2024-11-12T17:44:10.824Z	V6	Executing command	{"cmd": "/usr/bin/docker version --format {{.Client.Version}}"}
2024-11-12T17:44:10.844Z	V6	Executing command	{"cmd": "/usr/bin/docker info --format '{{json .MemTotal}}'"}
2024-11-12T17:44:10.887Z	V4	Reading bundles manifest	{"url": "./bin/local-bundle-release.yaml"}
2024-11-12T17:44:10.907Z	V4	Using CAPI provider versions	{"Core Cluster API": "v1.8.5+177bb52", "Kubeadm Bootstrap": "v1.8.5+206a28e", "Kubeadm Control Plane": "v1.8.5+68b2668", "External etcd Bootstrap": "v1.0.15+27fba9a", "External etcd Controller": "v1.0.24+048255b", "Cluster API Provider Nutanix": "v1.4.0+9156958"}
2024-11-12T17:44:11.038Z	V5	Retrier:	{"timeout": "2562047h47m16.854775807s", "backoffFactor": null}
2024-11-12T17:44:11.038Z	V2	Pulling docker image	{"image": "public.ecr.aws/l0g8r8j6/eks-anywhere-cli-tools:v0.21.0-eks-a-v0.22.0-dev-build.32"}
2024-11-12T17:44:11.038Z	V6	Executing command	{"cmd": "/usr/bin/docker pull public.ecr.aws/l0g8r8j6/eks-anywhere-cli-tools:v0.21.0-eks-a-v0.22.0-dev-build.32"}
2024-11-12T17:44:11.673Z	V5	Retry execution successful	{"retries": 1, "duration": "635.188522ms"}
2024-11-12T17:44:11.673Z	V3	Initializing long running container	{"name": "eksa_1731433451038317442", "image": "public.ecr.aws/l0g8r8j6/eks-anywhere-cli-tools:v0.21.0-eks-a-v0.22.0-dev-build.32"}
2024-11-12T17:44:11.673Z	V6	Executing command	{"cmd": "/usr/bin/docker run -d --name eksa_1731433451038317442 --network host -w /home/ubuntu/eksa-tests/fiql-fix -v /var/run/docker.sock:/var/run/docker.sock -v /home/ubuntu/eksa-tests/fiql-fix:/home/ubuntu/eksa-tests/fiql-fix -v /home/ubuntu/eksa-tests/fiql-fix:/home/ubuntu/eksa-tests/fiql-fix --entrypoint sleep public.ecr.aws/l0g8r8j6/eks-anywhere-cli-tools:v0.21.0-eks-a-v0.22.0-dev-build.32 infinity"}
2024-11-12T17:44:11.846Z	V1	Using the eksa controller to create the management cluster
2024-11-12T17:44:11.846Z	V4	Task start	{"task_name": "setup-validate"}
2024-11-12T17:44:11.846Z	V0	Performing setup and validations
2024-11-12T17:44:11.846Z	V0	ValidateClusterSpec for Nutanix datacenter	{"NutanixDatacenter": "eksa-ntnx-fiql-fix"}
2024-11-12T17:46:38.021Z	V0	✅ Nutanix Provider setup is valid
2024-11-12T17:46:38.021Z	V0	✅ Validate OS is compatible with registry mirror configuration
2024-11-12T17:46:38.021Z	V0	✅ Validate certificate for registry mirror
2024-11-12T17:46:38.021Z	V0	✅ Validate authentication for git provider
2024-11-12T17:46:38.021Z	V0	✅ Validate cluster's eksaVersion matches EKS-A version
2024-11-12T17:46:38.021Z	V4	Task finished	{"task_name": "setup-validate", "duration": "2m26.175237869s"}
2024-11-12T17:46:38.021Z	V4	----------------------------------
2024-11-12T17:46:38.021Z	V4	Task start	{"task_name": "bootstrap-cluster-init"}
2024-11-12T17:46:38.021Z	V0	Creating new bootstrap cluster
2024-11-12T17:46:38.022Z	V4	Creating kind cluster	{"name": "eksa-ntnx-fiql-fix-eks-a-cluster", "kubeconfig": "eksa-ntnx-fiql-fix/generated/eksa-ntnx-fiql-fix.kind.kubeconfig"}
2024-11-12T17:46:38.022Z	V6	Executing command	{"cmd": "/usr/bin/docker exec -i eksa_1731433451038317442 kind create cluster --name eksa-ntnx-fiql-fix-eks-a-cluster --kubeconfig eksa-ntnx-fiql-fix/generated/eksa-ntnx-fiql-fix.kind.kubeconfig --image public.ecr.aws/l0g8r8j6/kubernetes-sigs/kind/node:v1.30.5-eks-d-1-30-17-eks-a-v0.22.0-dev-build.32 --config eksa-ntnx-fiql-fix/generated/kind_tmp.yaml"}
2024-11-12T17:46:52.492Z	V5	Retrier:	{"timeout": "2562047h47m16.854775807s", "backoffFactor": null}
2024-11-12T17:46:52.492Z	V6	Executing command	{"cmd": "/usr/bin/docker exec -i eksa_1731433451038317442 kubectl get namespace eksa-system --kubeconfig eksa-ntnx-fiql-fix/generated/eksa-ntnx-fiql-fix.kind.kubeconfig"}
2024-11-12T17:46:52.648Z	V9	docker	{"stderr": "Error from server (NotFound): namespaces \"eksa-system\" not found\n"}
2024-11-12T17:46:52.648Z	V6	Executing command	{"cmd": "/usr/bin/docker exec -i eksa_1731433451038317442 kubectl create namespace eksa-system --kubeconfig eksa-ntnx-fiql-fix/generated/eksa-ntnx-fiql-fix.kind.kubeconfig"}
2024-11-12T17:46:52.788Z	V5	Retry execution successful	{"retries": 1, "duration": "296.079829ms"}
2024-11-12T17:46:52.788Z	V4	Task finished	{"task_name": "bootstrap-cluster-init", "duration": "14.766237292s"}
2024-11-12T17:46:52.788Z	V4	----------------------------------
2024-11-12T17:46:52.788Z	V4	Task start	{"task_name": "update-secrets-create"}
2024-11-12T17:46:52.788Z	V4	Task finished	{"task_name": "update-secrets-create", "duration": "1.896µs"}
2024-11-12T17:46:52.788Z	V4	----------------------------------
...
2024-11-12T18:00:05.056Z	V4	Deleting kind cluster	{"name": "eksa-ntnx-fiql-fix-eks-a-cluster"}
2024-11-12T18:00:05.056Z	V6	Executing command	{"cmd": "/usr/bin/docker exec -i eksa_1731433451038317442 kind delete cluster --name eksa-ntnx-fiql-fix-eks-a-cluster"}
2024-11-12T18:00:06.280Z	V5	Retry execution successful	{"retries": 1, "duration": "1.224249457s"}
2024-11-12T18:00:06.280Z	V0	🎉 Cluster created!
2024-11-12T18:00:06.280Z	V4	Task finished	{"task_name": "delete-kind-cluster", "duration": "1.620903207s"}
2024-11-12T18:00:06.280Z	V4	----------------------------------
2024-11-12T18:00:06.280Z	V4	Task start	{"task_name": "install-curated-packages"}
--------------------------------------------------------------------------------------
The Amazon EKS Anywhere Curated Packages are only available to customers with the
Amazon EKS Anywhere Enterprise Subscription
--------------------------------------------------------------------------------------
...

Documentation added/planned (if applicable):
Not required.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

Hi @adiantum. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Nov 12, 2024
@sp1999
Copy link
Member

sp1999 commented Nov 16, 2024

/ok-to-test

@codecov Codecov
Copy link

codecov bot commented Nov 16, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.

Project coverage is 72.42%. Comparing base (3a99b2a) to head (b287ec8).
Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
pkg/providers/nutanix/validator.go 97.56% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8997      +/-   ##
==========================================
+ Coverage   72.41%   72.42%   +0.01%     
==========================================
  Files         578      578              
  Lines       45386    45403      +17     
==========================================
+ Hits        32866    32883      +17     
  Misses      10790    10790              
  Partials     1730     1730

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

abhinavmpandey08
abhinavmpandey08 approved these changes Nov 22, 2024
View reviewed changes
Copy link
Member

@abhinavmpandey08 abhinavmpandey08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavmpandey08

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 195ea65 into aws:main Nov 22, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhinavmpandey08 abhinavmpandey08 abhinavmpandey08 approved these changes

Assignees

@abhinavmpandey08 abhinavmpandey08

Labels
approved lgtm ok-to-test size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adiantum @eks-distro-bot @sp1999 @abhinavmpandey08