Check image pushability based on image/tag count limits prior to push #8980
Conversation
eks-distro-bot
added
the
size/L
|
/retest |
abhay-krishna
force-pushed
the
check-image-pushability
branch
from
67b5afe to
7b1ad07
Compare
|
/hold |
abhay-krishna
force-pushed
the
check-image-pushability
branch
2 times, most recently
from
d2b4e8a to
2e40442
Compare
|
/retest |
abhay-krishna
force-pushed
the
check-image-pushability
branch
from
2e40442 to
74318e8
Compare
|
/lgtm |
|
/cherrypick release-0.21 |
|
@abhay-krishna: once the present PR merges, I will cherry-pick it on top of release-0.21 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-0.20 |
|
@abhay-krishna: once the present PR merges, I will cherry-pick it on top of release-0.20 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/unhold |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@abhay-krishna: new pull request created: #8998 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@abhay-krishna: new pull request created: #8999 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We have noticed that the image copy through Skopeo errors out when the destination repo has already hit the 10000 images mark or the 1000 tags per image mark, since these are the default limits set by ECR Public. In these cases, we should fail fast instead of retrying the image copy.
This PR adds logic to perform the check for images-per-repo and tags-per-repo on the destination ECR and fail early.
I tested this by building a small program with the actual ECR public bits (with credentials provided by my local AWS config file) and the checker method that returns the error. I created a repository and pushed 10000 images to it and tested the code against it.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.