-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove baremetal-branch flag from the integration test CLI #8967
Conversation
/cherry-pick release-0.21 |
@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.21 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-0.20 |
@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.20 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8967 +/- ##
=======================================
Coverage 72.41% 72.41%
=======================================
Files 578 578
Lines 45386 45386
=======================================
Hits 32866 32866
Misses 10790 10790
Partials 1730 1730 ☔ View full report in Codecov by Sentry. |
Also need to remove this line. |
c15e109
to
4591c64
Compare
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna, sp1999 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
4591c64
to
f78f856
Compare
f78f856
to
b74ad99
Compare
@sp1999: new pull request created: #8968 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@sp1999: new pull request created: #8969 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of changes:
This PR removes the
--baremetal-branch
flag from the integration test CLI as we no longer run tinkerbell tests simultaneously on multiple branches. This flag was introduced in #3201 more than two years ago to set the branch name for baremetal tests to run on. We now have additional mechanisms to prevent tests from being triggered from different branches at the same time so this flag doesn't add any value anymore. Since we started supporting n-1 EKS-A release branch too, we keep doing patch releases every 3 out of 4 weeks which requires us to run tests on release branches frequently. This change will reduce the headache of changing the secret value every time we do a patch release from main to release branch and then back to main. We also added periodic triggers for release pipelines to run tests on release branches every weekend at 7pm PST. But those pipelines don't have anything to handle changing the secret value before running the tests so this will also help in making sure that even tinkerbell tests run on the release branches every weekend. Overall, removing this flag adds a lot of value to our CI and release process.Testing (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.