Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use HookOS embedded images in Tinkerbell Templates: #8708

Merged
merged 2 commits into from
Sep 6, 2024

Update tests for embedded images:

b0a782a
Select commit
Loading
Failed to load commit list.
Merged

Use HookOS embedded images in Tinkerbell Templates: #8708

Update tests for embedded images:
b0a782a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 6, 2024 in 0s

73.57% (+0.02%) compared to 60152db

View this Pull Request on Codecov

73.57% (+0.02%) compared to 60152db

Details

Codecov Report

Attention: Patch coverage is 91.30435% with 4 lines in your changes missing coverage. Please review.

Project coverage is 73.57%. Comparing base (60152db) to head (b0a782a).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pkg/api/v1alpha1/tinkerbelltemplateconfig.go 0.00% 2 Missing ⚠️
...nywhere/cmd/generate_tinkerbell_template_config.go 0.00% 1 Missing ⚠️
pkg/providers/tinkerbell/template.go 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8708      +/-   ##
==========================================
+ Coverage   73.55%   73.57%   +0.02%     
==========================================
  Files         578      578              
  Lines       36580    36629      +49     
==========================================
+ Hits        26905    26951      +46     
+ Misses       7955     7951       -4     
- Partials     1720     1727       +7

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov