Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature flag for Kubernetes v1.31 support #8698

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Sep 3, 2024

Issue #, if available:
#2399

Description of changes:
Add feature flag for Kubernetes v1.31 support in EKS-A.

Testing (if applicable):
make eks-a
make unit-test
make build-all-test-binaries
make lint

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 3, 2024
@sp1999
Copy link
Member Author

sp1999 commented Sep 3, 2024

/approve

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.55%. Comparing base (e195e72) to head (24b6f7d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8698      +/-   ##
==========================================
+ Coverage   73.53%   73.55%   +0.01%     
==========================================
  Files         578      578              
  Lines       36557    36580      +23     
==========================================
+ Hits        26882    26905      +23     
  Misses       7955     7955              
  Partials     1720     1720              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@abhay-krishna abhay-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna, sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhay-krishna,sp1999]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 69c906b into aws:main Sep 3, 2024
12 checks passed
@sp1999 sp1999 deleted the 1.31-feature-flag branch September 3, 2024 02:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants