-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use correct Go version in E2E test JUnit files #8695
Conversation
/cherrypick release-0.19 |
@abhay-krishna: once the present PR merges, I will cherry-pick it on top of release-0.19 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-0.20 |
@abhay-krishna: once the present PR merges, I will cherry-pick it on top of release-0.20 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8695 +/- ##
=======================================
Coverage 73.53% 73.53%
=======================================
Files 578 578
Lines 36557 36557
=======================================
Hits 26882 26882
Misses 7955 7955
Partials 1720 1720 ☔ View full report in Codecov by Sentry. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sp1999 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@abhay-krishna: new pull request created: #8699 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@abhay-krishna: new pull request created: #8700 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Use correct Go version instead of old hardcoded Go version in E2E test JUnit files by dynamically retrieving the version from the
runtime
package in the Go standard library.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.