Ensure bundles override is used for template generation if available #8673
Conversation
eks-distro-bot
added
the
size/S
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8673 +/- ##
=======================================
Coverage 73.53% 73.53%
=======================================
Files 578 578
Lines 36557 36557
=======================================
Hits 26882 26882
Misses 7955 7955
Partials 1720 1720 ☔ View full report in Codecov by Sentry. |
abhay-krishna
force-pushed
the
use-bundles-override-for-template
branch
from
332a3de to
b5c1c91
Compare
abhay-krishna
force-pushed
the
use-bundles-override-for-template
branch
from
b5c1c91 to
390b36a
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sp1999 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherry-pick release-0.20 |
|
@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.20 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-0.19 |
|
@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.19 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@sp1999: new pull request created: #8693 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@sp1999: new pull request created: #8694 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We observed that for template generation, the staging E2E tests are not using the staging bundle manifest override (
bin/local-bundle-release.yaml) but are using the dev-release manifest corresponding to the test EKS-A CLI, and sometimes the dev one has older EKS-D versions than the staging bundle manifest, for example, in case a dev release for the release branch had not been run after an EKS Distro version bump. In this case, CLI preflight tag validations would fail for vSphere because the template was generated using one EKS-D version while another EKS-D version was used for the tag validation. We are fixing this by always using the bundles override for template generation if available.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.