Setup AWS profile for packages account only for bundle releases #8662
Conversation
eks-distro-bot
added
the
size/M
abhay-krishna
force-pushed
the
setup-packages-role
branch
from
e20c111 to
3ada242
Compare
|
/retest |
|
/lgtm |
|
/approve |
|
@abhay-krishna: once the present PR merges, I will cherry-pick it on top of release-0.20 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-0.19 |
|
@abhay-krishna: once the present PR merges, I will cherry-pick it on top of release-0.19 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/override eks-anywhere-generate-files-presubmit |
|
@abhay-krishna: Overrode contexts on behalf of abhay-krishna: eks-anywhere-generate-files-presubmit, eks-anywhere-release-tooling-presubmit In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@abhay-krishna: new pull request created: #8664 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@abhay-krishna: new pull request created: #8665 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
PR #8628 added logic to setup the AWS profile for packages beta account in order to pull the dev private packages images, but we actually need to do this only for the dev release and staging bundle release. Other types of releases don't need this profile setup as we don't need to pull images from the packages beta account. So this PR adds checks to ensure the profile setup and clients creation for packages happens only where necessary.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.