Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing vSphere E2E tests #8653

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

sp1999
Copy link
Member

@sp1999 sp1999 commented Aug 22, 2024

Description of changes:

This PR does the following in the vSphere E2E tests:

  • For packages tests, it adds the missing E2E tests for kubernetes v1.29 as they weren't added when we first started supporting it in Add 1.29 VSphere E2E tests #7562.
  • It also updates all the kubernetes v1.27 and v1.29 packages tests to regional curated packages tests as a follow-up to Curated packages tests using regional packages for vSphere #8569.
  • For all other tests, it adds the missing kubernetes v1.26 and v1.27 tests to cover all scenarios. For tests which have only test for an older kubernetes version, it updates that test to the latest kubernetes v1.30.

Overall, this PR adds 42 new vSphere tests and we had ~340 tests so far. So this will bring the total E2E tests count to ~380 which is above 360. This will set the testPerInstance value to 2 causing two tests to run sequentially on each instance. In order to bring it back to 1, this PR also increases the max EC2 count from 180 to 200.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Aug 22, 2024
@sp1999
Copy link
Member Author

sp1999 commented Aug 22, 2024

/cherry-pick release-0.20

@eks-distro-pr-bot
Copy link
Contributor

@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.20 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp1999
Copy link
Member Author

sp1999 commented Aug 22, 2024

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sp1999

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Aug 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.55%. Comparing base (69c906b) to head (4d415cc).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8653   +/-   ##
=======================================
  Coverage   73.54%   73.55%           
=======================================
  Files         578      578           
  Lines       36580    36580           
=======================================
+ Hits        26903    26905    +2     
+ Misses       7956     7955    -1     
+ Partials     1721     1720    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sp1999 sp1999 force-pushed the add-missing-1.29-tests branch from 4f5cd10 to 0c065c6 Compare August 23, 2024 00:55
@sp1999 sp1999 force-pushed the add-missing-1.29-tests branch from 0c065c6 to 4d415cc Compare September 3, 2024 04:14
@abhay-krishna
Copy link
Member

/lgtm

@eks-distro-bot eks-distro-bot merged commit 9a43146 into aws:main Sep 4, 2024
12 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@sp1999: new pull request created: #8704

In response to this:

/cherry-pick release-0.20

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sp1999 sp1999 deleted the add-missing-1.29-tests branch September 4, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants