-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing vSphere E2E tests #8653
Conversation
/cherry-pick release-0.20 |
@sp1999: once the present PR merges, I will cherry-pick it on top of release-0.20 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sp1999 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8653 +/- ##
=======================================
Coverage 73.54% 73.55%
=======================================
Files 578 578
Lines 36580 36580
=======================================
+ Hits 26903 26905 +2
+ Misses 7956 7955 -1
+ Partials 1721 1720 -1 ☔ View full report in Codecov by Sentry. |
4f5cd10
to
0c065c6
Compare
0c065c6
to
4d415cc
Compare
/lgtm |
@sp1999: new pull request created: #8704 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Description of changes:
This PR does the following in the vSphere E2E tests:
Overall, this PR adds 42 new vSphere tests and we had ~340 tests so far. So this will bring the total E2E tests count to ~380 which is above 360. This will set the testPerInstance value to 2 causing two tests to run sequentially on each instance. In order to bring it back to 1, this PR also increases the max EC2 count from 180 to 200.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.