Add e2e tests for RHEL 9 EFI on Baremetal #8649
Conversation
eks-distro-bot
added
the
size/L
2ez4szliu
force-pushed
the
rhel9-tinkerbell-e2e
branch
from
51c9fe1 to
8465d8a
Compare
2ez4szliu
force-pushed
the
rhel9-tinkerbell-e2e
branch
2 times, most recently
from
7c09242 to
c911802
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8649 +/- ##
=======================================
Coverage 73.58% 73.58%
=======================================
Files 578 578
Lines 36629 36629
=======================================
Hits 26953 26953
Misses 7950 7950
Partials 1726 1726 ☔ View full report in Codecov by Sentry. |
2ez4szliu
force-pushed
the
rhel9-tinkerbell-e2e
branch
from
c911802 to
b288aa6
Compare
2ez4szliu
force-pushed
the
rhel9-tinkerbell-e2e
branch
5 times, most recently
from
fd77389 to
fbda553
Compare
2ez4szliu
force-pushed
the
rhel9-tinkerbell-e2e
branch
from
fbda553 to
534f8f1
Compare
| For UEFI-enabled images, such as Ubuntu and RHEL 9, write actions use `DEST_DISK` to point to the second partition (for example, `/dev/sda2`), with the first being the EFI partition. | ||
| For all the write actions, `DEST_DISK` must be set to point to the root partition. | ||
| For Ubuntu, write actions use `DEST_DISK` to point to the second partition (for example, `/dev/sda2`), with the first being the EFI partition. | ||
| For RHEL 8 and RHEL 9, `DEST_DISK` is partition 1 (for example, `/dev/sda1`). |
There was a problem hiding this comment.
should this also be "pointed to" partition 1?
There was a problem hiding this comment.
changed all to "points to"
2ez4szliu
force-pushed
the
rhel9-tinkerbell-e2e
branch
from
534f8f1 to
b90d04f
Compare
- Add simple workflow test cases for RHEL 9 EFI on Baremetal. - Documentation improvement for RHEL 9 on Baremetal.
2ez4szliu
force-pushed
the
rhel9-tinkerbell-e2e
branch
from
b90d04f to
ab0f9da
Compare
|
/lgtm |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rahulbabu95 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| T_TINKERBELL_IMAGE_REDHAT_9_1_27: "tinkerbell_ci:image_redhat_9_1_27" | ||
| T_TINKERBELL_IMAGE_REDHAT_9_1_28: "tinkerbell_ci:image_redhat_9_1_28" | ||
| T_TINKERBELL_IMAGE_REDHAT_9_1_29: "tinkerbell_ci:image_redhat_9_1_29" | ||
| T_TINKERBELL_IMAGE_REDHAT_9_1_30: "tinkerbell_ci:image_redhat_9_1_30" |
There was a problem hiding this comment.
These also needs to be added to the quick-e2e-test buildspec here
*Issue #, if available:
Description of changes:
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.