Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kubelet configuration customization Docker cp and wn #8187

Merged
merged 1 commit into from
May 24, 2024

Conversation

mitalipaygude
Copy link
Member

@mitalipaygude mitalipaygude commented May 20, 2024

Issue #, if available:

Description of changes:
This PR adds a new field KubeletConfiguration in the eksa spec for control plane and worker node configuration. This is an unstructured object that is of the kind value KubeletConfiguration. This PR adds the code for Docker provider.

Testing (if applicable):

  • unit tests
  • e2e tests

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 20, 2024
Copy link

codecov bot commented May 20, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 73.41%. Comparing base (cd34399) to head (e8cdf7d).
Report is 7 commits behind head on main.

Files Patch % Lines
pkg/api/v1alpha1/cluster.go 83.33% 2 Missing and 2 partials ⚠️
pkg/providers/docker/docker.go 66.66% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8187      +/-   ##
==========================================
+ Coverage   73.40%   73.41%   +0.01%     
==========================================
  Files         577      577              
  Lines       35900    35936      +36     
==========================================
+ Hits        26352    26383      +31     
- Misses       7882     7884       +2     
- Partials     1666     1669       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitalipaygude mitalipaygude force-pushed the kc-docker branch 3 times, most recently from 8861335 to 42d9731 Compare May 21, 2024 07:16
@mitalipaygude
Copy link
Member Author

/test eks-anywhere-e2e-presubmit

@mitalipaygude mitalipaygude force-pushed the kc-docker branch 4 times, most recently from 2dd0c14 to 020796f Compare May 23, 2024 23:27
Copy link
Member

@abhinavmpandey08 abhinavmpandey08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/woof

@eks-distro-bot
Copy link
Collaborator

@abhinavmpandey08: dog image

In response to this:

/approve
/lgtm
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavmpandey08

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mitalipaygude mitalipaygude merged commit 0e112c0 into aws:main May 24, 2024
11 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants