Add emitting of e2e test instance metrics #8089
Conversation
eks-distro-bot
added
the
size/M
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8089 +/- ##
=======================================
Coverage 73.44% 73.44%
=======================================
Files 577 577
Lines 35878 35878
=======================================
Hits 26351 26351
Misses 7861 7861
Partials 1666 1666 ☔ View full report in Codecov by Sentry. |
|
/cherry-pick release-0.19 |
|
@d8660091: once the present PR merges, I will cherry-pick it on top of release-0.19 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
| } | ||
|
|
||
| logger.Info("Publishing instance test result metrics") | ||
| erroredCount, failedCount, succeededCount := 0, 0, 0 |
There was a problem hiding this comment.
Could you add a comment about why these counts are always either 0 or 1?
internal/test/e2e/cloudwatch.go
Outdated
| } | ||
|
|
||
| func getProviderName(testRe string) string { | ||
| providerRe := regexp.MustCompile(`Test([A-Z].*?)[A-Z]`) |
There was a problem hiding this comment.
Does this regex work for the vsphere and cloudstack test names? For example TestVSphereKubernetes128To129StackedEtcdRedHatUpgrade
TestCloudStackKubernetes128To129RedhatMultipleFieldsUpgrade
There was a problem hiding this comment.
it doesn't, good catch. I have updated the regexp with verification: https://go.dev/play/p/Ry5fK_qW64F
There was a problem hiding this comment.
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: d8660091 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@d8660091: new pull request created: #8098 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
Description of changes: E2e test results nowadays doesn't provide good observability. This change is aimed to start addressing this issue by adding cloudwatch metrics. It can further allow us to auto cut ticket based on the new e2e test metrics.
Testing (if applicable): manually triggered the e2e test and verified new metrics were emitted correctly
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.