Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log test runner instance config in e2e #8007

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Log test runner instance config in e2e #8007

merged 1 commit into from
Apr 18, 2024

Conversation

chrisdoherty4
Copy link
Contributor

Its difficult to understand what the configuration when launhcing a test runner is. This logs the configuration giving insight into IPs among other information.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 18, 2024
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.44%. Comparing base (6e42d97) to head (121f19a).
Report is 2 commits behind head on main.

❗ Current head 121f19a differs from pull request most recent head 6ec0a13. Consider uploading reports for the commit 6ec0a13 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8007      +/-   ##
==========================================
- Coverage   73.45%   73.44%   -0.01%     
==========================================
  Files         577      577              
  Lines       35862    35874      +12     
==========================================
+ Hits        26341    26347       +6     
- Misses       7855     7861       +6     
  Partials     1666     1666              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@abhinavmpandey08 abhinavmpandey08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavmpandey08

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 380f660 into aws:main Apr 18, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants