Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retry pulling artifacts when running download images cmd #8004

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Retry pulling artifacts when running download images cmd #8004

merged 1 commit into from
Apr 18, 2024

Conversation

chrisdoherty4
Copy link
Contributor

Pulling images and charts can fail due to network blips, rate limits and more. This retries pulling artifacts that are required for the download images cmd.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from chrisdoherty4. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 17, 2024
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

Attention: Patch coverage is 53.33333% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 73.44%. Comparing base (45b8acb) to head (6c4ba90).
Report is 6 commits behind head on main.

Files Patch % Lines
pkg/curatedpackages/curatedpackages.go 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8004      +/-   ##
==========================================
- Coverage   73.45%   73.44%   -0.01%     
==========================================
  Files         577      577              
  Lines       35862    35874      +12     
==========================================
+ Hits        26341    26347       +6     
- Misses       7855     7861       +6     
  Partials     1666     1666              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@abhinavmpandey08 abhinavmpandey08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@chrisdoherty4 chrisdoherty4 merged commit 55d37ae into aws:main Apr 18, 2024
10 of 12 checks passed
@chrisdoherty4 chrisdoherty4 deleted the feat/retry-image-pull branch April 18, 2024 18:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants