-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document steps to expose metrics for EKS-A components #7970
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7970 +/- ##
=======================================
Coverage 73.40% 73.40%
=======================================
Files 577 577
Lines 35900 35900
=======================================
Hits 26352 26352
Misses 7882 7882
Partials 1666 1666 ☔ View full report in Codecov by Sentry. |
docs/content/en/docs/clustermgmt/observability/expose-metrics.md
Outdated
Show resolved
Hide resolved
4967cbe
to
14071ef
Compare
docs/content/en/docs/clustermgmt/observability/expose-metrics.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/observability/expose-metrics.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/observability/expose-metrics.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/observability/expose-metrics.md
Outdated
Show resolved
Hide resolved
f2b731a
to
b7959e3
Compare
/lgtm |
docs/content/en/docs/clustermgmt/observability/expose-metrics.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/observability/expose-metrics.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/observability/expose-metrics.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/observability/expose-metrics.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. A lot of my comments were just that we spell out "EKS Anywhere" and "Kubernetes" in public docs.
docs/content/en/docs/clustermgmt/observability/expose-metrics.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/observability/expose-metrics.md
Outdated
Show resolved
Hide resolved
docs/content/en/docs/clustermgmt/observability/expose-metrics.md
Outdated
Show resolved
Hide resolved
b7959e3
to
76db8f3
Compare
76db8f3
to
772433b
Compare
772433b
to
e36f84e
Compare
/lgtm |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sp1999 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.19 |
@sp1999: new pull request created: #8167 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-0.18 |
@sp1999: new pull request created: #8168 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
#7875
#4299
#4405
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.