Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vsphere-spec.md #7964

Closed
wants to merge 1 commit into from
Closed

Update vsphere-spec.md #7964

wants to merge 1 commit into from

Conversation

d8660091
Copy link
Member

@d8660091 d8660091 commented Apr 11, 2024

Issue #, if available:

Description of changes: The CP IP 192.168.0.10 in the example is bad as it conflicts with the CIDR network

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from d8660091. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.42%. Comparing base (618bd05) to head (9f814be).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7964   +/-   ##
=======================================
  Coverage   73.42%   73.42%           
=======================================
  Files         577      577           
  Lines       35821    35821           
=======================================
  Hits        26302    26302           
  Misses       7854     7854           
  Partials     1665     1665           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d8660091 d8660091 closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation documentation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants