Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Clarify the networking example config #7962

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

raykrueger
Copy link
Contributor

The example config had an overlap between the POD cidr block and the control plane endpoint IP. Though it is documented in several places not to overlap this, the example config is confusing.

@eks-distro-bot
Copy link
Collaborator

Hi @raykrueger. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 11, 2024
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.42%. Comparing base (618bd05) to head (8faf158).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7962      +/-   ##
==========================================
- Coverage   73.42%   73.42%   -0.01%     
==========================================
  Files         577      577              
  Lines       35821    35821              
==========================================
- Hits        26302    26300       -2     
- Misses       7854     7855       +1     
- Partials     1665     1666       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eks-distro-bot eks-distro-bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 11, 2024
The example config had an overlap between the POD cidr block and the
control plane endpoint IP. Though it is documented in several places not
to overlap this, the example config is confusing.
@raykrueger raykrueger changed the title docs: Try and clarify the networking example config docs: Carify the networking example config Apr 11, 2024
@raykrueger raykrueger changed the title docs: Carify the networking example config docs: Clarify the networking example config Apr 11, 2024
@jiayiwang7
Copy link
Member

/approve
/cherry-pick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@jiayiwang7: once the present PR merges, I will cherry-pick it on top of release-0.19 in a new PR and assign it to you.

In response to this:

/approve
/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiayiwang7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit ffb3abe into aws:main Apr 11, 2024
7 of 8 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@jiayiwang7: new pull request created: #7966

In response to this:

/approve
/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm needs-ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants