Encode username and password in Kubernetes secrets #7829
Conversation
eks-distro-bot
added
the
size/L
abhay-krishna
force-pushed
the
data-for-secrets
branch
3 times, most recently
from
603ef88 to
a48a068
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7829 +/- ##
=======================================
Coverage 73.45% 73.45%
=======================================
Files 588 588
Lines 37153 37157 +4
=======================================
+ Hits 27289 27295 +6
+ Misses 8068 8067 -1
+ Partials 1796 1795 -1 ☔ View full report in Codecov by Sentry. |
abhay-krishna
force-pushed
the
data-for-secrets
branch
from
a48a068 to
ae2ba85
Compare
pkg/providers/vsphere/testdata/expected_cluster_api_server_cert_san_domain_name.yaml
Outdated
Show resolved
Hide resolved
abhay-krishna
force-pushed
the
data-for-secrets
branch
2 times, most recently
from
708df07 to
0bd8149
Compare
abhay-krishna
force-pushed
the
data-for-secrets
branch
from
0bd8149 to
2e5628f
Compare
|
/approve |
|
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavmpandey08 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-0.19 |
|
@abhay-krishna: new pull request created: #7833 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We need to encode the basic auth credentials to base64 when using them in templates to ensure that passwords containing special characters like escape characters and line separators are properly handled, and don't cause errors when unmarshaling or during
kubectl apply.Fixes: #7623
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.