Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify the incorrect command for generating a config file #7770

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

a2ush
Copy link
Contributor

@a2ush a2ush commented Mar 3, 2024

Issue:

For generating a config file, you need to use eksctl anywhere "generate" clusterconfig command.
eksctl anywhere "create" clusterconfig command does not work.

Description of changes:

Change the incorrect command eksctl anywhere create clusterconfig to eksctl anywhere generate clusterconfig.

Testing (if applicable):

$ eksctl anywhere generate clusterconfig baremetal-test --provider tinkerbell
apiVersion: anywhere.eks.amazonaws.com/v1alpha1
kind: Cluster
metadata:
  name: baremetal-test
...
$ eksctl anywhere create clusterconfig baremetal-test --provider tinkerbell
Error: unknown flag: --provider
Usage:
  anywhere create [command]

Available Commands:
  cluster     Create workload cluster
  package(s)  Create curated packages

Flags:
  -h, --help   help for create

Global Flags:
  -v, --verbosity int   Set the log level verbosity

Use "anywhere create [command] --help" for more information about a command.

Documentation added/planned (if applicable):

Modified

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

Hi @a2ush. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 3, 2024
@jacobweinstock
Copy link
Member

/ok-to-test

Copy link
Member

@jacobweinstock jacobweinstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, @a2ush !

@jacobweinstock
Copy link
Member

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobweinstock

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.61%. Comparing base (4583834) to head (5c1b5d6).
Report is 164 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7770      +/-   ##
==========================================
+ Coverage   73.48%   73.61%   +0.12%     
==========================================
  Files         579      588       +9     
  Lines       36357    37169     +812     
==========================================
+ Hits        26718    27362     +644     
- Misses       7875     8015     +140     
- Partials     1764     1792      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhay-krishna
Copy link
Member

/cherrypick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@abhay-krishna: once the present PR merges, I will cherry-pick it on top of release-0.19 in a new PR and assign it to you.

In response to this:

/cherrypick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhay-krishna abhay-krishna merged commit df2074e into aws:main Mar 4, 2024
6 of 8 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@abhay-krishna: new pull request created: #7773

In response to this:

/cherrypick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants