Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip cloudstack reconciler unit tests #7759

Merged

Conversation

panktishah26
Copy link
Member

@panktishah26 panktishah26 commented Mar 1, 2024

Issue #, if available:
https://github.com/aws/eks-anywhere-internal/issues/2193

Description of changes:
Skip flaky unit tests for CloudStack provider as a revert of this PR #7738

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.61%. Comparing base (4583834) to head (c71e834).
Report is 160 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7759      +/-   ##
==========================================
+ Coverage   73.48%   73.61%   +0.12%     
==========================================
  Files         579      588       +9     
  Lines       36357    37162     +805     
==========================================
+ Hits        26718    27357     +639     
- Misses       7875     8014     +139     
- Partials     1764     1791      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panktishah26 panktishah26 force-pushed the skip-cloudstack-reconciler-unit-tests branch from 5d2c522 to c71e834 Compare March 1, 2024 18:45
@eks-distro-bot eks-distro-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 1, 2024
@panktishah26
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: panktishah26

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@panktishah26 panktishah26 merged commit dee544d into aws:main Mar 1, 2024
10 of 12 checks passed
@panktishah26 panktishah26 deleted the skip-cloudstack-reconciler-unit-tests branch December 20, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants