Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarify vSphere CSI driver docs #7685

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Conversation

csplinter
Copy link
Member

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 22, 2024
@jiayiwang7
Copy link
Member

/retest

@jiayiwang7
Copy link
Member

/approve
/cherry-pick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@jiayiwang7: once the present PR merges, I will cherry-pick it on top of release-0.19 in a new PR and assign it to you.

In response to this:

/approve
/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jiayiwang7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csplinter
Copy link
Member Author

/retest

Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.60%. Comparing base (4583834) to head (fd42225).
Report is 131 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7685      +/-   ##
==========================================
+ Coverage   73.48%   73.60%   +0.11%     
==========================================
  Files         579      588       +9     
  Lines       36357    37150     +793     
==========================================
+ Hits        26718    27344     +626     
- Misses       7875     8014     +139     
- Partials     1764     1792      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jiayiwang7
Copy link
Member

/lgtm

@eks-distro-bot eks-distro-bot merged commit fa86162 into aws:main Feb 22, 2024
8 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@jiayiwang7: new pull request created: #7691

In response to this:

/approve
/cherry-pick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants