Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Updating CAPI v1.6.0 and controller runtime v0.17.0 #7682

Closed
wants to merge 4 commits into from

Conversation

pokearu
Copy link
Member

@pokearu pokearu commented Feb 22, 2024

Description of changes:
Updating CAPI and controller runtime dependency versions on EKS-A. This also includes pointing to newer versions for CAPI providers.

Changes to migrate from CAPI 1.4 https://cluster-api.sigs.k8s.io/developer/providers/migrations/v1.4-to-v1.5

Note: There is an open issue on controller-runtime where Fake client expects finalizers on objects added with a deletion timestamp. Hence incorporated those in our tests.
kubernetes-sigs/controller-runtime#2359

Testing (if applicable):
make unit-test

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from pokearu. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 75.82418% with 44 lines in your changes are missing coverage. Please review.

Project coverage is 73.54%. Comparing base (4583834) to head (1aa4d2c).
Report is 171 commits behind head on main.

Files Patch % Lines
pkg/api/v1alpha1/gitopsconfig_webhook.go 25.00% 6 Missing ⚠️
...api/v1alpha1/cloudstackdatacenterconfig_webhook.go 50.00% 5 Missing ⚠️
pkg/api/v1alpha1/fluxconfig_webhook.go 44.44% 5 Missing ⚠️
pkg/api/v1alpha1/oidcconfig_webhook.go 60.00% 4 Missing ⚠️
...kg/api/v1alpha1/tinkerbellmachineconfig_webhook.go 63.63% 4 Missing ⚠️
pkg/api/v1alpha1/awsiamconfig_webhook.go 62.50% 3 Missing ⚠️
...kg/api/v1alpha1/cloudstackmachineconfig_webhook.go 76.92% 3 Missing ⚠️
...kg/api/v1alpha1/vspheredatacenterconfig_webhook.go 75.00% 3 Missing ⚠️
pkg/api/v1alpha1/vspheremachineconfig_webhook.go 76.92% 3 Missing ⚠️
pkg/api/v1alpha1/cluster_webhook.go 81.81% 2 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7682      +/-   ##
==========================================
+ Coverage   73.48%   73.54%   +0.05%     
==========================================
  Files         579      588       +9     
  Lines       36357    37170     +813     
==========================================
+ Hits        26718    27337     +619     
- Misses       7875     8037     +162     
- Partials     1764     1796      +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pokearu pokearu force-pushed the updating-capi-deps branch 2 times, most recently from 99f7c20 to 10223c0 Compare March 4, 2024 17:50
@pokearu pokearu force-pushed the updating-capi-deps branch from 10223c0 to 26954c7 Compare March 5, 2024 03:55
@pokearu pokearu force-pushed the updating-capi-deps branch from 26954c7 to 84b8966 Compare March 5, 2024 04:21
@pokearu
Copy link
Member Author

pokearu commented Mar 5, 2024

/test eks-anywhere-e2e-presubmit

@pokearu
Copy link
Member Author

pokearu commented Mar 11, 2024

Closing this PR out since most changes went in with this PR #7788

@pokearu pokearu closed this Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants