Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix machine rollout during mgmt delete #7674

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

tatlat
Copy link
Member

@tatlat tatlat commented Feb 22, 2024

Issue #, if available:

Description of changes:
Deleting a mgmt cluster after upgrading managment-components caused new machines to rollout during delete. Rather than waiting for the machines to rollout during delete, we should keep the EKS-Anywhere cluster on the bootstrap paused, and allow the controller to delete while the cluster is still paused.

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 22, 2024
Copy link

codecov bot commented Feb 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4583834) 73.48% compared to head (fe794e4) 73.60%.
Report is 126 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7674      +/-   ##
==========================================
+ Coverage   73.48%   73.60%   +0.11%     
==========================================
  Files         579      588       +9     
  Lines       36357    37146     +789     
==========================================
+ Hits        26718    27342     +624     
- Misses       7875     8013     +138     
- Partials     1764     1791      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatlat tatlat force-pushed the fix-delete-rollout branch from 26297e7 to fe794e4 Compare February 22, 2024 00:49
@mitalipaygude
Copy link
Member

/woof

@eks-distro-bot
Copy link
Collaborator

@mitalipaygude: dog image

In response to this:

/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tatlat
Copy link
Member Author

tatlat commented Feb 22, 2024

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tatlat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit dd9d07b into aws:main Feb 22, 2024
13 checks passed
@mitalipaygude
Copy link
Member

/cherrypick release-0.19

@eks-distro-pr-bot
Copy link
Contributor

@mitalipaygude: new pull request created: #7676

In response to this:

/cherrypick release-0.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants