-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix machine rollout during mgmt delete #7674
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7674 +/- ##
==========================================
+ Coverage 73.48% 73.60% +0.11%
==========================================
Files 579 588 +9
Lines 36357 37146 +789
==========================================
+ Hits 26718 27342 +624
- Misses 7875 8013 +138
- Partials 1764 1791 +27 ☔ View full report in Codecov by Sentry. |
26297e7
to
fe794e4
Compare
/woof |
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tatlat The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherrypick release-0.19 |
@mitalipaygude: new pull request created: #7676 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
Description of changes:
Deleting a mgmt cluster after upgrading managment-components caused new machines to rollout during delete. Rather than waiting for the machines to rollout during delete, we should keep the EKS-Anywhere cluster on the bootstrap paused, and allow the controller to delete while the cluster is still paused.
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.