Fix workload cluster kube-vip update #7624
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rahul Ganesh <[email protected]>
eks-distro-bot
added
the
size/L
Signed-off-by: Rahul Ganesh <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7624 +/- ##
==========================================
+ Coverage 73.48% 73.53% +0.05%
==========================================
Files 579 588 +9
Lines 36357 37178 +821
==========================================
+ Hits 26718 27340 +622
- Misses 7875 8039 +164
- Partials 1764 1799 +35 ☔ View full report in Codecov by Sentry. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhinavmpandey08 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
When updating kube-vip manifest for workload cluster, we need the remote client to be able to create the config map with kube-vip manifest data. This change uses remote client instead of management client to create the kube-vip config map for InPlace upgrades. Additionally the upgrader pod is also set to restart on failure as a retry mechanism.
Description of changes:
Testing (if applicable):
Tested locally for workload cluster upgrade using InPlace strategy
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.