Revert Tinkerbell upgrade management components e2e test to use kube 1.28 #7617
Conversation
|
Skipping CI for Draft Pull Request. |
eks-distro-bot
added
the
size/XS
cxbrowne1207
changed the title
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cxbrowne1207 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
test/e2e/tinkerbell_test.go
Outdated
| @@ -1623,7 +1623,7 @@ func TestTinkerbellSingleNode128To129UbuntuManagementCPUpgradeAPI(t *testing.T) | |||
| ) | |||
| } | |||
|
|
|||
| func TestTinkerbellKubernetes129UpgradeManagementComponents(t *testing.T) { | |||
| func TestTinkerbellKubernetes128UpgradeManagementComponents(t *testing.T) { | |||
| release := latestMinorRelease(t) | |||
| provider := framework.NewTinkerbell(t, framework.WithUbuntu129Tinkerbell()) | |||
There was a problem hiding this comment.
This needs to be 128 too right?
There was a problem hiding this comment.
You are correct! Thanks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7617 +/- ##
==========================================
+ Coverage 73.48% 73.70% +0.21%
==========================================
Files 579 588 +9
Lines 36357 37099 +742
==========================================
+ Hits 26718 27344 +626
- Misses 7875 7962 +87
- Partials 1764 1793 +29 ☔ View full report in Codecov by Sentry. |
cxbrowne1207
force-pushed
the
fix-tinkerbell-e2e
branch
from
0f70a52 to
b933cc6
Compare
eks-distro-bot
added
size/S
Issue #, if available:
Description of changes:
The test is trying to make a 1.29 cluster using the newest minor release, but that's not allowed yet. We can only do that after 1.29 is out, with version 0.19.0. Until then, the test needs to be set up for 1.28 instead. This goes for any test trying to set up a 1.29 cluster from the latest minor release.
This PR reverts it to use kube 1.28 instead
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.