Add KMS v1 feature gate for Kubernetes v1.29 #7613
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eks-distro-bot
added
the
size/XXL
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7613 +/- ##
==========================================
+ Coverage 73.48% 73.66% +0.17%
==========================================
Files 579 581 +2
Lines 36357 36936 +579
==========================================
+ Hits 26718 27209 +491
- Misses 7875 7937 +62
- Partials 1764 1790 +26 ☔ View full report in Codecov by Sentry. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The KMS v1 provider was deprecated in Kubernetes v1.28 and disabled by default in Kubernetes v1.29, in favor of the KMS V2 provider . To use KMS v1 in Kubernetes v1.29, we need to set the API server feature gate
KMSv1=true. This PR adds the feature flag to our cluster templates, along with unit tests verifying the feature gate gets added for Kubernetes v1.29.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.