Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove feature flag for create #7609

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Conversation

mitalipaygude
Copy link
Member

Issue #, if available:

Description of changes:
Remove feature flag for create
Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 15, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 83 lines in your changes are missing coverage. Please review.

Comparison is base (4583834) 73.48% compared to head (0a5a5ef) 73.59%.
Report is 78 commits behind head on main.

Files Patch % Lines
controllers/kubeadmcontrolplane_controller.go 64.00% 5 Missing and 4 partials ⚠️
controllers/machinedeployment_controller.go 52.63% 5 Missing and 4 partials ⚠️
pkg/providers/tinkerbell/validate.go 73.68% 4 Missing and 1 partial ⚠️
pkg/providers/vsphere/vsphere.go 0.00% 5 Missing ⚠️
pkg/clustermanager/cluster_manager.go 78.94% 4 Missing ⚠️
pkg/providers/docker/docker.go 55.55% 3 Missing and 1 partial ⚠️
pkg/providers/snow/snow.go 0.00% 4 Missing ⚠️
release/api/v1alpha1/artifacts.go 0.00% 4 Missing ⚠️
pkg/kubeconfig/kubeconfig_writer.go 40.00% 1 Missing and 2 partials ⚠️
pkg/workflows/management/create_install_eksa.go 57.14% 2 Missing and 1 partial ⚠️
... and 20 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7609      +/-   ##
==========================================
+ Coverage   73.48%   73.59%   +0.10%     
==========================================
  Files         579      580       +1     
  Lines       36357    36663     +306     
==========================================
+ Hits        26718    26983     +265     
- Misses       7875     7902      +27     
- Partials     1764     1778      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tatlat
Copy link
Member

tatlat commented Feb 15, 2024

/lgtm
/approve
/woof

@eks-distro-bot
Copy link
Collaborator

@tatlat: dog image

In response to this:

/lgtm
/approve
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: tatlat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mitalipaygude mitalipaygude merged commit c9adafb into aws:main Feb 15, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved do-not-merge/hold lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants