Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable MultiEndpoint CloudStack Tests #7606

Merged

Conversation

jonathanmeier5
Copy link
Member

Description of changes:
Disable tests.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 15, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4583834) 73.48% compared to head (f3353fa) 73.56%.
Report is 87 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7606      +/-   ##
==========================================
+ Coverage   73.48%   73.56%   +0.08%     
==========================================
  Files         579      580       +1     
  Lines       36357    36662     +305     
==========================================
+ Hits        26718    26972     +254     
- Misses       7875     7913      +38     
- Partials     1764     1777      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jonathanmeier5 jonathanmeier5 force-pushed the disable-multi-endpoint-tests branch from 2351c81 to f3353fa Compare February 15, 2024 19:39
@drewvanstone drewvanstone added this to the v0.19.0 milestone Feb 15, 2024
Copy link
Member

@drewvanstone drewvanstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@abhay-krishna
Copy link
Member

/lgtm

@abhay-krishna
Copy link
Member

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 0fc97a4 into aws:main Feb 16, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants