Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Kubernetes v1.29 feature flag and make it the default cluster version #7598

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

abhay-krishna
Copy link
Member

This PR removes the feature flag for Kubernetes v1.29 support and make it the default cluster version.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@abhay-krishna
Copy link
Member Author

/hold

@eks-distro-bot eks-distro-bot added do-not-merge/hold size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 15, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4583834) 73.48% compared to head (7a8df81) 73.52%.
Report is 108 commits behind head on main.

❗ Current head 7a8df81 differs from pull request most recent head 29ff726. Consider uploading reports for the commit 29ff726 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7598      +/-   ##
==========================================
+ Coverage   73.48%   73.52%   +0.03%     
==========================================
  Files         579      588       +9     
  Lines       36357    37155     +798     
==========================================
+ Hits        26718    27319     +601     
- Misses       7875     8038     +163     
- Partials     1764     1798      +34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@drewvanstone drewvanstone added this to the v0.19.0 milestone Feb 15, 2024
@abhay-krishna
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhay-krishna
Copy link
Member Author

/override eks-anywhere-presubmit eks-anywhere-generate-files-presubmits eks-anywhere-e2e-presubmit

@eks-distro-bot
Copy link
Collaborator

@abhay-krishna: Overrode contexts on behalf of abhay-krishna: eks-anywhere-e2e-presubmit, eks-anywhere-generate-files-presubmits, eks-anywhere-presubmit

In response to this:

/override eks-anywhere-presubmit eks-anywhere-generate-files-presubmits eks-anywhere-e2e-presubmit

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@abhay-krishna
Copy link
Member Author

/unhold

@eks-distro-bot eks-distro-bot merged commit b204d01 into aws:main Feb 20, 2024
10 checks passed
@abhay-krishna abhay-krishna deleted the 1.29-default-version branch March 6, 2024 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants