Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write AWS IAM kubeconfig file for workload cluster #7596

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

mitalipaygude
Copy link
Member

@mitalipaygude mitalipaygude commented Feb 15, 2024

Issue #, if available:

Description of changes:
Write AWS IAM kubeconfig file for workload cluster

Testing (if applicable):

  • manual tested e2e

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 15, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 76 lines in your changes are missing coverage. Please review.

Comparison is base (4583834) 73.48% compared to head (2dcb30e) 73.55%.
Report is 69 commits behind head on main.

Files Patch % Lines
controllers/kubeadmcontrolplane_controller.go 64.00% 5 Missing and 4 partials ⚠️
controllers/machinedeployment_controller.go 52.63% 5 Missing and 4 partials ⚠️
pkg/workflows/workload/writeclusterconfig.go 0.00% 5 Missing and 1 partial ⚠️
pkg/providers/tinkerbell/validate.go 73.68% 4 Missing and 1 partial ⚠️
pkg/providers/vsphere/vsphere.go 0.00% 5 Missing ⚠️
pkg/clustermanager/cluster_manager.go 78.94% 4 Missing ⚠️
pkg/providers/snow/snow.go 0.00% 4 Missing ⚠️
release/api/v1alpha1/artifacts.go 0.00% 4 Missing ⚠️
pkg/providers/docker/docker.go 0.00% 3 Missing ⚠️
pkg/workflows/management/create_workload.go 78.57% 2 Missing and 1 partial ⚠️
... and 15 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7596      +/-   ##
==========================================
+ Coverage   73.48%   73.55%   +0.06%     
==========================================
  Files         579      580       +1     
  Lines       36357    36643     +286     
==========================================
+ Hits        26718    26951     +233     
- Misses       7875     7916      +41     
- Partials     1764     1776      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rahulbabu95
Copy link
Member

/lgtm

@abhay-krishna
Copy link
Member

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mitalipaygude mitalipaygude merged commit 92e403d into aws:main Feb 15, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants