Update kube-vip for InPlace upgrades. #7595
Conversation
eks-distro-bot
added
the
size/L
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7595 +/- ##
==========================================
+ Coverage 73.48% 73.59% +0.10%
==========================================
Files 579 580 +1
Lines 36357 36722 +365
==========================================
+ Hits 26718 27024 +306
- Misses 7875 7919 +44
- Partials 1764 1779 +15 ☔ View full report in Codecov by Sentry. |
| ObjectMeta: metav1.ObjectMeta{ | ||
| Name: constants.KubeVipConfigMapName, | ||
| Namespace: constants.EksaSystemNamespace, | ||
| OwnerReferences: []metav1.OwnerReference{{ |
There was a problem hiding this comment.
This is good but this doesn't ensure it gets cleaned up right away right? Meaning, if a new CPUpgrade needs to get created with the same name due to some subsequent upgrade, we will never get the new CM for this if it never gets deleted?
There was a problem hiding this comment.
That's a good point. I will clean it up once all the nodes are upgraded for a given cpu. This way we ensure we always clean it after a successful upgrade.
There was a problem hiding this comment.
I think when you have BlockOwnerDeletion set on the child object, it blocks the parent object deletion. @rahulbabu95 you can test it out just to be sure
Signed-off-by: Rahul Ganesh <[email protected]>
rahulbabu95
force-pushed
the
inplace/update-kubevip-manifest
branch
from
439eecb to
c6c5b9c
Compare
|
/retest |
| cm := &corev1.ConfigMap{} | ||
| if err := client.Get(ctx, GetNamespacedNameType(constants.KubeVipConfigMapName, constants.EksaSystemNamespace), cm); err != nil { | ||
| if apierrors.IsNotFound(err) { | ||
| log.Info("config map %s not found, skipping deletion", "ConfigMap", constants.KubeVipConfigMapName, "Namespace", constants.EksaSystemNamespace) |
There was a problem hiding this comment.
nit
| log.Info("config map %s not found, skipping deletion", "ConfigMap", constants.KubeVipConfigMapName, "Namespace", constants.EksaSystemNamespace) | |
| log.Info("config map %s not found, skipping deletion", "ConfigMap", constants.KubeVipConfigMapName, "Namespace", constants.EksaSystemNamespace) |
| kubeVipConfig = file.Content | ||
| break | ||
| } | ||
| } |
There was a problem hiding this comment.
can you add a check here to see kubeVipConfig is not empty after the for loop? incase the kube-vip is not found in files, just error out
pkg/constants/constants.go
Outdated
| @@ -48,6 +48,9 @@ const ( | |||
| EksaPackagesName = "eksa-packages" | |||
| // UpgraderConfigMapName is the name of config map that stores the upgrader images. | |||
| UpgraderConfigMapName = "in-place-upgrade" | |||
| // KubeVipConfigMapName is the name of config map that stores the kube-vip config. | |||
| KubeVipConfigMapName = "kube-vip-in-place-upgrade" | |||
| KubeVipManifestName = "kube-vip.yaml" | |||
There was a problem hiding this comment.
nit: add comment for KubeVipManifestName
Signed-off-by: Rahul Ganesh <[email protected]>
|
/retest |
1 similar comment
|
/retest |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rahulbabu95 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/override eks-anywhere-e2e-presubmit |
|
@rahulbabu95: Overrode contexts on behalf of rahulbabu95: eks-anywhere-e2e-presubmit In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
Kube-vip is deployed as static pod which means during any eksd/k8s version upgrade InPlace, we need to also update the kube-vip manifest with the new image for InPlace upgrades. This change parses the udpated Kube-vip manifest from
KubeadmControlPlaneSpec.KubeadmConfigSpecand uses a config map mounted to the upgrader pod to facilitate kube-vip update for InPlace. The upgrader script then uses the volume mount to update the kube-vip manifest onto the host.Description of changes:
Testing (if applicable):
Tested the changes locally.
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.