Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.29 Tinkerbell E2E #7591

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

panktishah26
Copy link
Member

Issue #, if available:
Part of https://github.com/aws/eks-anywhere-internal/issues/2045

Description of changes:
Add e2e tests for Kubernetes version 1.29

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Feb 15, 2024
Copy link

codecov bot commented Feb 15, 2024

Codecov Report

Attention: 48 lines in your changes are missing coverage. Please review.

Comparison is base (4583834) 73.48% compared to head (9aefbad) 73.57%.
Report is 73 commits behind head on main.

Files Patch % Lines
pkg/providers/tinkerbell/validate.go 73.68% 4 Missing and 1 partial ⚠️
pkg/providers/vsphere/vsphere.go 0.00% 5 Missing ⚠️
pkg/clustermanager/cluster_manager.go 78.94% 4 Missing ⚠️
pkg/providers/snow/snow.go 0.00% 4 Missing ⚠️
release/api/v1alpha1/artifacts.go 0.00% 4 Missing ⚠️
pkg/providers/docker/docker.go 0.00% 3 Missing ⚠️
pkg/workflows/management/create_workload.go 78.57% 2 Missing and 1 partial ⚠️
pkg/workflows/management/secrets.go 80.00% 3 Missing ⚠️
pkg/providers/nutanix/controlplane.go 92.00% 1 Missing and 1 partial ⚠️
pkg/providers/nutanix/provider.go 77.77% 1 Missing and 1 partial ⚠️
... and 10 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7591      +/-   ##
==========================================
+ Coverage   73.48%   73.57%   +0.08%     
==========================================
  Files         579      580       +1     
  Lines       36357    36642     +285     
==========================================
+ Hits        26718    26958     +240     
- Misses       7875     7909      +34     
- Partials     1764     1775      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panktishah26 panktishah26 force-pushed the add-tinkerbell-1-29-e2e branch 2 times, most recently from c0526c7 to 883be48 Compare February 15, 2024 04:12
@panktishah26
Copy link
Member Author

/test eks-anywhere-e2e-validate-tinkerbell-hardware-presubmit
/test eks-anywhere-e2e-presubmit

@panktishah26 panktishah26 force-pushed the add-tinkerbell-1-29-e2e branch from 883be48 to 41c5df3 Compare February 15, 2024 07:24
@panktishah26 panktishah26 force-pushed the add-tinkerbell-1-29-e2e branch from 41c5df3 to 9aefbad Compare February 15, 2024 18:00
Copy link
Member

@abhay-krishna abhay-krishna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit af7336b into aws:main Feb 15, 2024
13 checks passed
@panktishah26 panktishah26 deleted the add-tinkerbell-1-29-e2e branch December 20, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants