Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a validation if the controller is paused during cluster upgrade #7585

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

panktishah26
Copy link
Member

Issue #, if available:
https://github.com/aws/eks-anywhere-internal/issues/2189

Description of changes:
We have enabled controller for all the cluster operations. Cluster upgrade process succeds and doesn't show any error if the customer pauses controller reconciler manually by annotating cluster with anywhere.eks.amazonaws.com/paused=true annotation. With this PR, the cluster upgrade command will give following error if the cluster reconciler is paused before upgrading the cluster.

❌ Validation failed {"validation": "validate eksa controller is not paused", "error": "remove cluster controller reconciliation pause annotation anywhere.eks.amazonaws.com/paused before upgrading cluster docker", "remediation": "ensure cluster controller reconciliation is not paused manually before upgrading the cluster"}

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 14, 2024
@panktishah26 panktishah26 force-pushed the pause-controller-validation branch from 657246b to f17945d Compare February 14, 2024 21:52
Copy link

codecov bot commented Feb 14, 2024

Codecov Report

Attention: 33 lines in your changes are missing coverage. Please review.

Comparison is base (4583834) 73.48% compared to head (48f4077) 73.54%.
Report is 63 commits behind head on main.

Files Patch % Lines
pkg/providers/tinkerbell/validate.go 73.68% 4 Missing and 1 partial ⚠️
release/api/v1alpha1/artifacts.go 0.00% 4 Missing ⚠️
pkg/workflows/management/secrets.go 80.00% 3 Missing ⚠️
pkg/clustermanager/cluster_manager.go 88.23% 2 Missing ⚠️
pkg/providers/nutanix/controlplane.go 92.00% 1 Missing and 1 partial ⚠️
pkg/validations/cluster.go 71.42% 1 Missing and 1 partial ⚠️
pkg/workflows/management/create_workload.go 71.42% 1 Missing and 1 partial ⚠️
pkg/workflows/workload/create_gitops.go 84.61% 2 Missing ⚠️
pkg/workflows/workload/post_delete.go 84.61% 2 Missing ⚠️
cmd/eksctl-anywhere/cmd/deletecluster.go 0.00% 1 Missing ⚠️
... and 8 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7585      +/-   ##
==========================================
+ Coverage   73.48%   73.54%   +0.05%     
==========================================
  Files         579      580       +1     
  Lines       36357    36562     +205     
==========================================
+ Hits        26718    26890     +172     
- Misses       7875     7905      +30     
- Partials     1764     1767       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@panktishah26 panktishah26 force-pushed the pause-controller-validation branch from f17945d to 48f4077 Compare February 14, 2024 23:24
@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 7543166 into aws:main Feb 15, 2024
12 checks passed
@panktishah26 panktishah26 deleted the pause-controller-validation branch December 20, 2024 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants