-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate snow provider environment variable map using management components #7568
Conversation
Skipping CI for Draft Pull Request. |
f5313a5
to
b70a403
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7568 +/- ##
==========================================
+ Coverage 73.48% 73.56% +0.07%
==========================================
Files 579 580 +1
Lines 36357 36504 +147
==========================================
+ Hits 26718 26854 +136
- Misses 7875 7887 +12
+ Partials 1764 1763 -1 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cxbrowne1207 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available:
Context:
The newly introduced upgrade
management-components
commands is currently building a new cluster spec and running validations against it. We do not want to do this because the users cluster spec updates are not applied while upgrading management components. Specifically, one problem that arises is that if your cluster is currently running a deprecated version of Kubernetes in EKS Anywhere (right now Kubernetes 1.24), the CLI will fail upgrading the management components when building the new cluster spec.This is because Kubernetes 1.24 is not supported now and does not exist in the new bundles .
As a solution to this, we want to remove the need to build the new full
cluster.Spec
in the upgrade management-components workflow. For this to be possible, we need to remove the need for thecluster.Spec
when accessing management component information during the upgrade.Description of changes:
This PR changes the snow provider to generate the environment variable map information using management components. It still uses the *cluster.Spec (presumably the current cluster spec) for any addition information, for snow the credentials secret
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.