Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Remove feature flag for controller via CLI (#7546)" #7554

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

mitalipaygude
Copy link
Member

This reverts commit 1034e51.

Issue #, if available:

Description of changes:
Revert "Remove feature flag for controller via CLI (#7546)"
Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 12, 2024
Copy link
Member

@abhinavmpandey08 abhinavmpandey08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavmpandey08

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (4583834) 73.48% compared to head (22481c1) 73.55%.
Report is 36 commits behind head on main.

Files Patch % Lines
pkg/workflows/management/create_workload.go 0.00% 5 Missing and 1 partial ⚠️
pkg/providers/tinkerbell/validate.go 73.68% 4 Missing and 1 partial ⚠️
release/api/v1alpha1/artifacts.go 0.00% 4 Missing ⚠️
pkg/workflows/management/secrets.go 80.00% 3 Missing ⚠️
pkg/clustermanager/cluster_manager.go 88.23% 2 Missing ⚠️
pkg/providers/nutanix/controlplane.go 92.00% 1 Missing and 1 partial ⚠️
pkg/workflows/workload/create_gitops.go 84.61% 2 Missing ⚠️
pkg/workflows/workload/post_delete.go 84.61% 2 Missing ⚠️
cmd/eksctl-anywhere/cmd/deletecluster.go 0.00% 1 Missing ⚠️
cmd/eksctl-anywhere/cmd/validations.go 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7554      +/-   ##
==========================================
+ Coverage   73.48%   73.55%   +0.06%     
==========================================
  Files         579      580       +1     
  Lines       36357    36496     +139     
==========================================
+ Hits        26718    26843     +125     
- Misses       7875     7889      +14     
  Partials     1764     1764              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eks-distro-bot eks-distro-bot merged commit 43ef11f into aws:main Feb 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants