Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to set tests to run in quick e2e buildspec #7553

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

g-gaston
Copy link
Member

@g-gaston g-gaston commented Feb 12, 2024

Description of changes:
This allows to manually run a pipeline with this buildspec and running only one or a particular subset of tests.

It introduces the value "QUICK" that allows to run all configured tests for the quick pipeline without knowing the tests. This allows a manual pipeline to run all quick tests without passing an empty variable, which is not allowed.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 12, 2024
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (4583834) 73.48% compared to head (db822fb) 73.57%.
Report is 39 commits behind head on main.

Files Patch % Lines
cmd/eksctl-anywhere/cmd/version.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7553      +/-   ##
==========================================
+ Coverage   73.48%   73.57%   +0.08%     
==========================================
  Files         579      580       +1     
  Lines       36357    36480     +123     
==========================================
+ Hits        26718    26839     +121     
- Misses       7875     7877       +2     
  Partials     1764     1764              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@g-gaston g-gaston force-pushed the allow-for-quick-test-override branch 2 times, most recently from 47f60d7 to 8e1dde9 Compare February 12, 2024 18:55
This allows to manually run a pipeline with this buildspec and running
only one or a particular subset of tests.

It introduces the value "QUICK" that allows to run all configured tests
for the quick pipeline without knowing the tests. This allows a manual
pipeline to run all quick tests without passing an empty variable, which
is not allowed.
@g-gaston g-gaston force-pushed the allow-for-quick-test-override branch from 8e1dde9 to db822fb Compare February 12, 2024 19:22
@d8660091
Copy link
Member

/lgtm

@g-gaston
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: g-gaston

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@g-gaston
Copy link
Member Author

/test eks-anywhere-e2e-presubmit

@g-gaston
Copy link
Member Author

/test eks-anywhere-presubmit

@eks-distro-bot eks-distro-bot merged commit 840c6f3 into aws:main Feb 12, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants