Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests to quick e2e suite from existing tests #7540

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

cxbrowne1207
Copy link
Member

@cxbrowne1207 cxbrowne1207 commented Feb 9, 2024

Issue #, if available:

Description of changes:

  • Add existing tests from the e2e test suite to quick tests suite.
  • Add new vSphere test variables

Testing (if applicable):
Manually invoke CI to run tests

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Feb 9, 2024
@cxbrowne1207 cxbrowne1207 force-pushed the add-tests-to-quick-e2e-suite branch 2 times, most recently from 3d6d32d to 3bf6046 Compare February 9, 2024 17:28
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Comparison is base (4583834) 73.48% compared to head (da168b0) 73.57%.
Report is 35 commits behind head on main.

Files Patch % Lines
pkg/workflows/management/create_workload.go 0.00% 5 Missing and 1 partial ⚠️
pkg/providers/tinkerbell/validate.go 73.68% 4 Missing and 1 partial ⚠️
release/api/v1alpha1/artifacts.go 0.00% 4 Missing ⚠️
pkg/workflows/management/secrets.go 80.00% 3 Missing ⚠️
pkg/clustermanager/cluster_manager.go 88.23% 2 Missing ⚠️
pkg/providers/nutanix/controlplane.go 92.00% 1 Missing and 1 partial ⚠️
pkg/workflows/workload/create_gitops.go 84.61% 2 Missing ⚠️
pkg/workflows/workload/post_delete.go 84.61% 2 Missing ⚠️
cmd/eksctl-anywhere/cmd/deletecluster.go 0.00% 1 Missing ⚠️
cmd/eksctl-anywhere/cmd/validations.go 0.00% 1 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7540      +/-   ##
==========================================
+ Coverage   73.48%   73.57%   +0.08%     
==========================================
  Files         579      580       +1     
  Lines       36357    36480     +123     
==========================================
+ Hits        26718    26841     +123     
- Misses       7875     7876       +1     
+ Partials     1764     1763       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cxbrowne1207 cxbrowne1207 force-pushed the add-tests-to-quick-e2e-suite branch 4 times, most recently from 17831c9 to f1b9087 Compare February 10, 2024 21:10
@eks-distro-bot eks-distro-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 11, 2024
@cxbrowne1207 cxbrowne1207 force-pushed the add-tests-to-quick-e2e-suite branch 2 times, most recently from 839466f to a23214f Compare February 12, 2024 12:10
@eks-distro-bot eks-distro-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 12, 2024
@cxbrowne1207 cxbrowne1207 marked this pull request as ready for review February 12, 2024 15:24
@cxbrowne1207 cxbrowne1207 force-pushed the add-tests-to-quick-e2e-suite branch from 3bb60d0 to 0a64149 Compare February 12, 2024 15:46
@cxbrowne1207 cxbrowne1207 force-pushed the add-tests-to-quick-e2e-suite branch from 0a64149 to da168b0 Compare February 12, 2024 16:10
@d8660091
Copy link
Member

/lgtm

@cxbrowne1207
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cxbrowne1207

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 4de7cda into aws:main Feb 12, 2024
11 checks passed
@cxbrowne1207 cxbrowne1207 deleted the add-tests-to-quick-e2e-suite branch February 12, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants