Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move kube-vip manifest modification step to pre-kubeadm commands for Nutanix #7536

Merged
merged 1 commit into from
Feb 9, 2024

Conversation

abhay-krishna
Copy link
Member

Because this command was being placed in postKubeadmCommands section of the preKubeadmCommands, the control plane nodes were unable to get properly initialized since the kube-vip pod wouldn't have the necessary permissions to acquire the lease it needs to for managing the VIP.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 9, 2024
@abhay-krishna abhay-krishna changed the title Move kube-vip manifest modification step to pre-kubeadm commands Move kube-vip manifest modification step to pre-kubeadm commands for Nutanix Feb 9, 2024
Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (4583834) 73.48% compared to head (ef22dde) 73.52%.
Report is 24 commits behind head on main.

Files Patch % Lines
pkg/providers/tinkerbell/validate.go 73.33% 4 Missing ⚠️
pkg/workflows/management/secrets.go 80.00% 3 Missing ⚠️
cmd/eksctl-anywhere/cmd/version.go 0.00% 1 Missing ⚠️
release/api/v1alpha1/artifacts.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7536      +/-   ##
==========================================
+ Coverage   73.48%   73.52%   +0.03%     
==========================================
  Files         579      579              
  Lines       36357    36421      +64     
==========================================
+ Hits        26718    26779      +61     
- Misses       7875     7879       +4     
+ Partials     1764     1763       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhay-krishna
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhay-krishna
Copy link
Member Author

/override eks-anywhere-e2e-presubmit
Irrelevant but stuck in retesting churn

@eks-distro-bot
Copy link
Collaborator

@abhay-krishna: Overrode contexts on behalf of abhay-krishna: eks-anywhere-e2e-presubmit

In response to this:

/override eks-anywhere-e2e-presubmit
Irrelevant but stuck in retesting churn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot merged commit 7a59cc5 into aws:main Feb 9, 2024
11 checks passed
@abhay-krishna abhay-krishna deleted the nutanix-prekubeadm branch March 6, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants