-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move kube-vip manifest modification step to pre-kubeadm commands for Nutanix #7536
Conversation
13c224d
to
ef22dde
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #7536 +/- ##
==========================================
+ Coverage 73.48% 73.52% +0.03%
==========================================
Files 579 579
Lines 36357 36421 +64
==========================================
+ Hits 26718 26779 +61
- Misses 7875 7879 +4
+ Partials 1764 1763 -1 ☔ View full report in Codecov by Sentry. |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/override eks-anywhere-e2e-presubmit |
@abhay-krishna: Overrode contexts on behalf of abhay-krishna: eks-anywhere-e2e-presubmit In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Because this command was being placed in
postKubeadmCommands
section of thepreKubeadmCommands
, the control plane nodes were unable to get properly initialized since thekube-vip
pod wouldn't have the necessary permissions to acquire the lease it needs to for managing the VIP.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.