Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add one Snow test to quick e2e test suite #7510

Merged
merged 1 commit into from
Feb 8, 2024

Conversation

cxbrowne1207
Copy link
Member

@cxbrowne1207 cxbrowne1207 commented Feb 7, 2024

Issue #, if available:

Description of changes:
Adding one Snow test to the e2e suite.

  • Added all the required environment variables to the quick e2e code build spec yaml
  • Added TestSnowKubernetes128SimpleFlow to the QUICK_TESTS.yaml. It is disabled for now until we move the current tests to nightly, being cognizant of infrastructure limitations.

Testing (if applicable):

  • Manually invoking the codebuild project and sourcing the changes on this branch

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@cxbrowne1207 cxbrowne1207 changed the title Add one snow test to quick e2e test suite Add one Snow test to quick e2e test suite Feb 7, 2024
@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 7, 2024
@cxbrowne1207 cxbrowne1207 marked this pull request as ready for review February 7, 2024 20:12
Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4583834) 73.48% compared to head (36bae7a) 73.48%.
Report is 11 commits behind head on main.

❗ Current head 36bae7a differs from pull request most recent head d885a34. Consider uploading reports for the commit d885a34 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7510   +/-   ##
=======================================
  Coverage   73.48%   73.48%           
=======================================
  Files         579      579           
  Lines       36357    36357           
=======================================
  Hits        26718    26718           
  Misses       7875     7875           
  Partials     1764     1764           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cxbrowne1207 cxbrowne1207 force-pushed the add-snow-quick-e2e-test branch from a4b0c0e to 36bae7a Compare February 7, 2024 20:31
@cxbrowne1207 cxbrowne1207 force-pushed the add-snow-quick-e2e-test branch from 36bae7a to d885a34 Compare February 8, 2024 15:59
@d8660091
Copy link
Member

d8660091 commented Feb 8, 2024

/lgtm

@cxbrowne1207
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cxbrowne1207

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 412db7a into aws:main Feb 8, 2024
9 checks passed
@cxbrowne1207 cxbrowne1207 deleted the add-snow-quick-e2e-test branch February 9, 2024 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants