-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CNI docs #7335
base: main
Are you sure you want to change the base?
Update CNI docs #7335
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7335 +/- ##
==========================================
+ Coverage 71.72% 73.48% +1.76%
==========================================
Files 559 578 +19
Lines 43368 36489 -6879
==========================================
- Hits 31104 26814 -4290
+ Misses 10549 7956 -2593
- Partials 1715 1719 +4 ☔ View full report in Codecov by Sentry. |
for a cluster, and the plugin cannot be changed once the cluster is created. | ||
Up until the 0.7.x releases, the plugin had to be specified using the `cni` field on cluster spec. | ||
Starting with release 0.8, the plugin should be specified using the new `cniConfig` field as follows: | ||
EKS Anywhere officially supports Cilium for production level providers as a CNI plugin. The plugin cannot be changed once the cluster is created. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove "production level" ... it's supported on all providers
We need to clarify "The plugin cannot be changed once the cluster is created". This is not true. A customer can replace the default EKS-A Cilium with another CNI such as Enterprise Cilium
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, I clarified that they cannot replace the CNI by changing the cniConfig field and added a link to the custom CNI section on the same page.
Co-authored-by: Drew Flower <[email protected]>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
--- | ||
|
||
### Specifying CNI Plugin in EKS Anywhere cluster spec | ||
### Specifying CNI Plugin in EKS Anywhere cluster yaml spec | ||
|
||
#### Provider support details | ||
| | vSphere | Bare Metal | Nutanix | CloudStack | Snow | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given we only support a single CNI it must work on every provider so this table is superfluous. Mind removing it?
@@ -269,7 +247,7 @@ and the node CIDR mask size is `24`. This ensures the cluster 256 blocks of /24 | |||
|
|||
To support more than 256 nodes, the cluster CIDR block needs to be large, and the node CIDR mask size needs to be |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we rewrite this section:
To support more than 256 nodes adjust the pod CIDR block and node CIDR mask size.
Pod CIDR Node CIDR Mask Max Nodes Max Pods/Node* 192.168.0.0/16 24 256 256 192.168.0.0/16 25 512 128 192.168.0.0/15 24 512 256 192.168.0.0/15 25 1024 128 * Includes system pods.
Co-authored-by: Chris Doherty <[email protected]>
Co-authored-by: Chris Doherty <[email protected]>
Co-authored-by: Chris Doherty <[email protected]>
Co-authored-by: Chris Doherty <[email protected]>
Issue #, if available:
Description of changes:
Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.