Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CNI docs #7335

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Update CNI docs #7335

wants to merge 7 commits into from

Conversation

tatlat
Copy link
Member

@tatlat tatlat commented Jan 19, 2024

Issue #, if available:

Description of changes:

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jan 19, 2024
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.48%. Comparing base (5a474bf) to head (e9d4b13).
Report is 652 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7335      +/-   ##
==========================================
+ Coverage   71.72%   73.48%   +1.76%     
==========================================
  Files         559      578      +19     
  Lines       43368    36489    -6879     
==========================================
- Hits        31104    26814    -4290     
+ Misses      10549     7956    -2593     
- Partials     1715     1719       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

for a cluster, and the plugin cannot be changed once the cluster is created.
Up until the 0.7.x releases, the plugin had to be specified using the `cni` field on cluster spec.
Starting with release 0.8, the plugin should be specified using the new `cniConfig` field as follows:
EKS Anywhere officially supports Cilium for production level providers as a CNI plugin. The plugin cannot be changed once the cluster is created.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "production level" ... it's supported on all providers

We need to clarify "The plugin cannot be changed once the cluster is created". This is not true. A customer can replace the default EKS-A Cilium with another CNI such as Enterprise Cilium

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, I clarified that they cannot replace the CNI by changing the cniConfig field and added a link to the custom CNI section on the same page.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from drewvanstone. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tatlat tatlat requested a review from drewvanstone January 31, 2024 23:05
docs/content/en/docs/getting-started/optional/cni.md Outdated Show resolved Hide resolved
docs/content/en/docs/getting-started/optional/cni.md Outdated Show resolved Hide resolved
---

### Specifying CNI Plugin in EKS Anywhere cluster spec
### Specifying CNI Plugin in EKS Anywhere cluster yaml spec

#### Provider support details
| | vSphere | Bare Metal | Nutanix | CloudStack | Snow |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given we only support a single CNI it must work on every provider so this table is superfluous. Mind removing it?

docs/content/en/docs/getting-started/optional/cni.md Outdated Show resolved Hide resolved
docs/content/en/docs/getting-started/optional/cni.md Outdated Show resolved Hide resolved
@@ -269,7 +247,7 @@ and the node CIDR mask size is `24`. This ensures the cluster 256 blocks of /24

To support more than 256 nodes, the cluster CIDR block needs to be large, and the node CIDR mask size needs to be
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we rewrite this section:

To support more than 256 nodes adjust the pod CIDR block and node CIDR mask size.

Pod CIDR Node CIDR Mask Max Nodes Max Pods/Node*
192.168.0.0/16 24 256 256
192.168.0.0/16 25 512 128
192.168.0.0/15 24 512 256
192.168.0.0/15 25 1024 128

* Includes system pods.

@drewvanstone drewvanstone added this to the v0.19.0 milestone Feb 15, 2024
@drewvanstone drewvanstone modified the milestones: v0.19.0, backlog Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/docs Documentation documentation size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants