Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bottlerocket for Baremetal is being deprecated: #7310

Merged

Conversation

jacobweinstock
Copy link
Member

Issue #, if available:

Description of changes:
Removing e2e related tests. Leaving 3 simple flow tests until Bottlerocket support is removed.

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Removing e2e related tests. Leaving 3 simple flow
tests until Bottlerocket support is removed.

Signed-off-by: Jacob Weinstock <[email protected]>
@eks-distro-bot eks-distro-bot added the size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. label Jan 17, 2024
@jacobweinstock
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jacobweinstock

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (413ea04) 71.65% compared to head (9970c28) 71.67%.
Report is 15 commits behind head on main.

Files Patch % Lines
pkg/workflows/management/validate.go 78.12% 6 Missing and 1 partial ⚠️
pkg/workflows/management/upgrade.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7310      +/-   ##
==========================================
+ Coverage   71.65%   71.67%   +0.02%     
==========================================
  Files         556      557       +1     
  Lines       43185    43238      +53     
==========================================
+ Hits        30944    30991      +47     
- Misses      10532    10537       +5     
- Partials     1709     1710       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@chrisdoherty4
Copy link
Contributor

/lgtm

@eks-distro-bot eks-distro-bot merged commit 683fd7a into aws:main Jan 19, 2024
12 checks passed
@DanielRis
Copy link

Is there any additional information available for this deprecation? I was not able to find any announcement or documentation why Bottlerocket gets removed.

@bdwyertech
Copy link

Is there any additional information available for this deprecation? I was not able to find any announcement or documentation why Bottlerocket gets removed.

@jacobweinstock Is there a link to more discussion/decision with this? We also use Bottlerocket on bare metal.

@Cajga
Copy link
Contributor

Cajga commented Jan 26, 2024

Sounds really interesting (we had to build our own ubuntu image due to CSI limitations on Bottlerocket). Do you plan to return to support Ubuntu out of the box with tinkerbell?

@jacobweinstock
Copy link
Member Author

Hey @DanielRis , @bdwyertech and @Cajga , apologies for the delayed response. Here's the official announcement: bottlerocket-os/bottlerocket#3794

@jacobweinstock jacobweinstock deleted the remove-tinkerbell-bottlerocket-e2e branch February 21, 2024 22:12
@sp1999 sp1999 mentioned this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants