Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add change log for patch 18.4 #7288

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Conversation

rahulbabu95
Copy link
Member

Issue #, if available:

Description of changes:

Testing (if applicable):

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Rahul Ganesh <[email protected]>
@eks-distro-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 11, 2024
Signed-off-by: Rahul Ganesh <[email protected]>
@rahulbabu95 rahulbabu95 marked this pull request as ready for review January 11, 2024 22:38
@rahulbabu95
Copy link
Member Author

/hold

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a4fc7a6) 71.63% compared to head (a4f7645) 71.63%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7288   +/-   ##
=======================================
  Coverage   71.63%   71.63%           
=======================================
  Files         556      556           
  Lines       43204    43190   -14     
=======================================
- Hits        30949    30940    -9     
+ Misses      10544    10539    -5     
  Partials     1711     1711           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Rahul Ganesh <[email protected]>
Copy link
Member

@cxbrowne1207 cxbrowne1207 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@rahulbabu95
Copy link
Member Author

/unhold

@rahulbabu95
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rahulbabu95

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 397bba3 into aws:main Jan 12, 2024
9 checks passed
@rahulbabu95
Copy link
Member Author

/cherrypick release-0.18

@eks-distro-pr-bot
Copy link
Contributor

@rahulbabu95: new pull request created: #7297

In response to this:

/cherrypick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants