Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IAM Roles for Service Accounts to nutanix-spec.md doc #7285

Merged

Conversation

yannickstruyf3
Copy link
Contributor

Issue #, if available:
N/A
Description of changes:
Update of the nutanix-spec.md to include "IAM Roles for Service Accounts" configuration

Testing (if applicable):
N/A

Documentation added/planned (if applicable):
Update of the nutanix-spec.md to include "IAM Roles for Service Accounts" configuration

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

Hi @yannickstruyf3. Thanks for your PR.

I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot eks-distro-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 11, 2024
@abhay-krishna
Copy link
Member

/lgtm
/approve
/ok-to-test
/cherrypick release-0.18

@eks-distro-pr-bot
Copy link
Contributor

@abhay-krishna: once the present PR merges, I will cherry-pick it on top of release-0.18 in a new PR and assign it to you.

In response to this:

/lgtm
/approve
/ok-to-test
/cherrypick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Jan 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (025d06f) 71.63% compared to head (fd2b026) 71.64%.
Report is 45 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7285   +/-   ##
=======================================
  Coverage   71.63%   71.64%           
=======================================
  Files         556      556           
  Lines       43204    43204           
=======================================
+ Hits        30949    30952    +3     
+ Misses      10544    10542    -2     
+ Partials     1711     1710    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhay-krishna abhay-krishna merged commit 324a314 into aws:main Jan 21, 2024
7 of 9 checks passed
@eks-distro-pr-bot
Copy link
Contributor

@abhay-krishna: new pull request created: #7338

In response to this:

/lgtm
/approve
/ok-to-test
/cherrypick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/docs Documentation documentation lgtm ok-to-test size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants