-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add IAM Roles for Service Accounts to nutanix-spec.md doc #7285
Add IAM Roles for Service Accounts to nutanix-spec.md doc #7285
Conversation
Hi @yannickstruyf3. Thanks for your PR. I'm waiting for a aws member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
@abhay-krishna: once the present PR merges, I will cherry-pick it on top of release-0.18 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: abhay-krishna The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7285 +/- ##
=======================================
Coverage 71.63% 71.64%
=======================================
Files 556 556
Lines 43204 43204
=======================================
+ Hits 30949 30952 +3
+ Misses 10544 10542 -2
+ Partials 1711 1710 -1 ☔ View full report in Codecov by Sentry. |
@abhay-krishna: new pull request created: #7338 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
N/A
Description of changes:
Update of the nutanix-spec.md to include "IAM Roles for Service Accounts" configuration
Testing (if applicable):
N/A
Documentation added/planned (if applicable):
Update of the nutanix-spec.md to include "IAM Roles for Service Accounts" configuration
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.