Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update latest version only if semver is greater than previous latest #7244

Merged

Conversation

abhay-krishna
Copy link
Member

Backporting #7237 to release-0.17. Copying over the semver package methods instead of importing to avoid having to do the release module refactor to change the direction of imports between the main module and release submodule.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 2, 2024
Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (92a4246) 75.60% compared to head (1478c06) 75.60%.

Additional details and impacted files
@@              Coverage Diff              @@
##           release-0.17    #7244   +/-   ##
=============================================
  Coverage         75.60%   75.60%           
=============================================
  Files               458      458           
  Lines             38077    38077           
=============================================
  Hits              28787    28787           
  Misses             7678     7678           
  Partials           1612     1612           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhay-krishna
Copy link
Member Author

/approve

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhay-krishna

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit 4e71336 into aws:release-0.17 Jan 2, 2024
10 checks passed
@abhay-krishna abhay-krishna deleted the backport-semver-fix-0.17 branch March 6, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants