Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.29 Docker E2E tests #7154

Merged
merged 1 commit into from
Feb 7, 2024
Merged

Conversation

abhay-krishna
Copy link
Member

Add Kubernetes v1.29 E2E tests for Docker provider.

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot eks-distro-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 11, 2023
@abhay-krishna abhay-krishna force-pushed the 1.29-docker-e2e branch 2 times, most recently from bbfd6d9 to f39f02a Compare December 11, 2023 18:43
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (6dc52b5) 72.03% compared to head (4bfd32e) 73.47%.
Report is 6 commits behind head on main.

Files Patch % Lines
pkg/providers/snow/apibuilder.go 60.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7154      +/-   ##
==========================================
+ Coverage   72.03%   73.47%   +1.44%     
==========================================
  Files         579      579              
  Lines       44704    36344    -8360     
==========================================
- Hits        32202    26705    -5497     
+ Misses      10740     7875    -2865     
- Partials     1762     1764       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@abhay-krishna abhay-krishna force-pushed the 1.29-docker-e2e branch 2 times, most recently from 14cdd7d to 9a92a6e Compare January 3, 2024 04:30
Copy link
Member

@abhinavmpandey08 abhinavmpandey08 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm
/woof

@eks-distro-bot
Copy link
Collaborator

@abhinavmpandey08: dog image

In response to this:

/approve
/lgtm
/woof

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavmpandey08

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@abhay-krishna abhay-krishna merged commit 1578630 into aws:main Feb 7, 2024
9 of 11 checks passed
@abhay-krishna abhay-krishna deleted the 1.29-docker-e2e branch March 6, 2024 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants