Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider DefaultCNIConfiguredCondition in Ready condition except when Skip Upgrades is enabled #7118

Conversation

cxbrowne1207
Copy link
Member

@cxbrowne1207 cxbrowne1207 commented Dec 1, 2023

Issue #, if available:

Description of changes:
This PR adds logic to consider the status of the DefaultCNIConfiguredCondition in the overall Cluster status Ready condition. However, it is only considered in the computation of the Ready status when the reason for DefaultCNIConfiguredCondition not being ready is SkipUpgradesForDefaultCNIConfigured, which is used when skipUpgrades is enabled for the default cni.

Testing (if applicable):

  • Created workload cluster using API
  • Upgraded workload cluster from 1.27 to 1.28 using API
  • Created workload cluster using CLI
  • Upgraded workload cluster from 1.27 to 1.28 using CLI (using kindless upgrades)

Documentation added/planned (if applicable):

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@eks-distro-bot
Copy link
Collaborator

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@eks-distro-bot eks-distro-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 1, 2023
@cxbrowne1207
Copy link
Member Author

/test all

Copy link

codecov bot commented Dec 1, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (a1dbf9c) 71.56% compared to head (ebbe46c) 71.58%.
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7118      +/-   ##
==========================================
+ Coverage   71.56%   71.58%   +0.02%     
==========================================
  Files         545      545              
  Lines       42323    42358      +35     
==========================================
+ Hits        30288    30323      +35     
  Misses      10343    10343              
  Partials     1692     1692              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@eks-distro-bot eks-distro-bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 4, 2023
@cxbrowne1207 cxbrowne1207 marked this pull request as ready for review December 4, 2023 17:45
@jiayiwang7
Copy link
Member

/lgtm

@eks-distro-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eks-distro-bot eks-distro-bot merged commit fec15e4 into aws:main Dec 6, 2023
7 checks passed
@cxbrowne1207 cxbrowne1207 deleted the include-default-cni-status-in-ready-condition branch December 6, 2023 04:03
@cxbrowne1207
Copy link
Member Author

/cherry-pick release-0.18

@eks-distro-pr-bot
Copy link
Contributor

@cxbrowne1207: new pull request created: #7132

In response to this:

/cherry-pick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants