-
Notifications
You must be signed in to change notification settings - Fork 289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider DefaultCNIConfiguredCondition in Ready condition except when Skip Upgrades is enabled #7118
Consider DefaultCNIConfiguredCondition in Ready condition except when Skip Upgrades is enabled #7118
Conversation
Skipping CI for Draft Pull Request. |
/test all |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7118 +/- ##
==========================================
+ Coverage 71.56% 71.58% +0.02%
==========================================
Files 545 545
Lines 42323 42358 +35
==========================================
+ Hits 30288 30323 +35
Misses 10343 10343
Partials 1692 1692 ☔ View full report in Codecov by Sentry. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-0.18 |
@cxbrowne1207: new pull request created: #7132 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Issue #, if available:
Description of changes:
This PR adds logic to consider the status of the
DefaultCNIConfiguredCondition
in the overallCluster
statusReady
condition. However, it is only considered in the computation of theReady
status when the reason forDefaultCNIConfiguredCondition
not being ready isSkipUpgradesForDefaultCNIConfigured
, which is used when skipUpgrades is enabled for the default cni.Testing (if applicable):
Documentation added/planned (if applicable):
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.